Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425334AbdDUTgm (ORCPT ); Fri, 21 Apr 2017 15:36:42 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37508 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425186AbdDUTgi (ORCPT ); Fri, 21 Apr 2017 15:36:38 -0400 Date: Fri, 21 Apr 2017 15:36:35 -0400 (EDT) Message-Id: <20170421.153635.1878323052363882645.davem@davemloft.net> To: nikolay@cumulusnetworks.com Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, dvyukov@google.com, kcc@google.com, syzkaller@googlegroups.com, edumazet@google.com, roopa@cumulusnetworks.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ip6mr: fix notification device destruction From: David Miller In-Reply-To: <6d7dca26-4bc6-870c-8eb9-409f6c6b8fd5@cumulusnetworks.com> References: <1492796536-28781-1-git-send-email-nikolay@cumulusnetworks.com> <6d7dca26-4bc6-870c-8eb9-409f6c6b8fd5@cumulusnetworks.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Apr 2017 11:55:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 16 From: Nikolay Aleksandrov Date: Fri, 21 Apr 2017 21:30:42 +0300 > On 21/04/17 20:42, Nikolay Aleksandrov wrote: >> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >> because we call unregister_netdevice_many for a device that is already >> being destroyed. In IPv4's ipmr that has been resolved by two commits >> long time ago by introducing the "notify" parameter to the delete >> function and avoiding the unregister when called from a notifier, so >> let's do the same for ip6mr. ... > +CC LKML and Linus Applied, thanks Nikolay and thanks Andrey for the report and testing. Nikolay, how far does this bug go back?