Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425443AbdDUTjO (ORCPT ); Fri, 21 Apr 2017 15:39:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42028 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425349AbdDUTjM (ORCPT ); Fri, 21 Apr 2017 15:39:12 -0400 Date: Fri, 21 Apr 2017 22:37:17 +0300 From: Dan Carpenter To: Jens Axboe , Christoph Hellwig Cc: Johannes Thumshirn , Hannes Reinecke , Bart Van Assche , Sachin Shukla , Pan Bian , Ming Lei , Eric Biggers , Mike Christie , Dan Williams , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup() Message-ID: <20170421193717.u2cxdq2jyithqqxi@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 28 We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. It's weird that GCC doesn't catch this. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Dan Carpenter --- Not tested, please review carefully. diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 66a6bd83faae..bd4bf70a5bcd 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -4105,14 +4105,12 @@ static int mtip_block_initialize(struct driver_data *dd) static void mtip_no_dev_cleanup(struct request *rq, void *data, bool reserv) { struct driver_data *dd = (struct driver_data *)data; - struct mtip_cmd *cmd; + struct mtip_cmd *cmd = mtip_cmd_from_tag(dd, MTIP_TAG_INTERNAL); if (likely(!reserv)) { cmd->status = -ENODEV; blk_mq_complete_request(rq); } else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, &dd->port->flags)) { - - cmd = mtip_cmd_from_tag(dd, MTIP_TAG_INTERNAL); if (cmd->comp_func) cmd->comp_func(dd->port, MTIP_TAG_INTERNAL, cmd, -ENODEV);