Subject: Re: [PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Christoph Hellwig <hch@lst.de>
References: <20170421193717.u2cxdq2jyithqqxi@mwanda>
CC: Johannes Thumshirn <jthumshirn@suse.de>,
        Hannes Reinecke <hare@suse.com>,
        Bart Van Assche <Bart.VanAssche@sandisk.com>,
        Sachin Shukla <sachin.s5@samsung.com>, Pan Bian <bianpan2016@163.com>,
        Ming Lei <tom.leiming@gmail.com>, Eric Biggers <ebiggers@google.com>,
        Mike Christie <mchristi@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
From: Jens Axboe <axboe@fb.com>
Message-ID: <0bb97411-d1bd-5c6c-69d0-a7bceb69efa7@fb.com>
Date: Fri, 21 Apr 2017 13:39:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170421193717.u2cxdq2jyithqqxi@mwanda>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2017 19:39:58.3716 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1197
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-21_15:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1263
Lines: 34

On 04/21/2017 01:37 PM, Dan Carpenter wrote:
> We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet.
> It's weird that GCC doesn't catch this.

That is weird...

> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 66a6bd83faae..bd4bf70a5bcd 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -4105,14 +4105,12 @@ static int mtip_block_initialize(struct driver_data *dd)
>  static void mtip_no_dev_cleanup(struct request *rq, void *data, bool reserv)
>  {
>  	struct driver_data *dd = (struct driver_data *)data;
> -	struct mtip_cmd *cmd;
> +	struct mtip_cmd *cmd = mtip_cmd_from_tag(dd, MTIP_TAG_INTERNAL);
>  
>  	if (likely(!reserv)) {
>  		cmd->status = -ENODEV;
>  		blk_mq_complete_request(rq);
>  	} else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, &dd->port->flags)) {
> -
> -		cmd = mtip_cmd_from_tag(dd, MTIP_TAG_INTERNAL);
>  		if (cmd->comp_func)
>  			cmd->comp_func(dd->port, MTIP_TAG_INTERNAL,
>  					cmd, -ENODEV);

This is wrong, you can't use the internal tag bit for both cases. A proper
fix was already merged earlier today:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.12/block&id=95c55ff425faa190fd8ba55090fbdf33d8b2f0ae

-- 
Jens Axboe