Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162527AbdDUVwi convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2017 17:52:38 -0400 Received: from mga05.intel.com ([192.55.52.43]:51078 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425948AbdDUVwd (ORCPT ); Fri, 21 Apr 2017 17:52:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,231,1488873600"; d="scan'208";a="90790347" From: "Kushwaha, Priyalee" To: Josh Triplett CC: "paulmck@linux.vnet.ibm.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" Subject: RE: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Thread-Topic: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Thread-Index: AQHSusOFxAzLr9/gXkSCtjcYjalkMKHQn0iA//+9XOA= Date: Fri, 21 Apr 2017 21:52:10 +0000 Message-ID: References: <1ad554b0025913fedf4ec3c7953d1a42fe1f0dde.1492879165.git.priyalee.kushwaha@intel.com> <20170421184721.GA28159@cloud> In-Reply-To: <20170421184721.GA28159@cloud> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3073 Lines: 71 Tested 9 distros centos, Debian, Fedora, Gentoo, Opensuse, slackware, Ubuntu, poky showed awk at /usr/bin/awk. Here is another similar patch which has been approved https://patchwork.kernel.org/patch/9650581/ centos-7: lrwxrwxrwx 1 root root 4 Mar 15 19:58 /bin/awk -> gawk lrwxrwxrwx 1 root root 4 Mar 15 19:58 /usr/bin/awk -> gawk Debian-8: ls: cannot access /bin/awk: No such file or directory lrwxrwxrwx 1 root root 21 Mar 20 23:26 /usr/bin/awk -> /etc/alternatives/awk Fedora: lrwxrwxrwx. 1 root root 4 Sep 12 2016 /bin/awk -> gawk lrwxrwxrwx. 1 root root 4 Sep 12 2016 /usr/bin/awk -> gawk Gentoo: lrwxrwxrwx 1 root root 15 Jan 1 13:57 /bin/awk -> ../usr/bin/gawk lrwxrwxrwx 1 root root 4 Jan 1 13:57 /usr/bin/awk -> gawk Opensuse: lrwxrwxrwx 1 root root 21 Mar 20 11:19 /bin/awk -> /etc/alternatives/awk lrwxrwxrwx 1 root root 29 Mar 20 11:19 /usr/bin/awk -> /etc/alternatives/usr-bin-awk Slackware: lrwxrwxrwx 1 root root 4 Mar 10 15:37 /bin/awk -> gawk lrwxrwxrwx 1 root root 13 Mar 10 15:37 /usr/bin/awk -> ../../bin/awk Ubuntu: ls: cannot access '/bin/awk': No such file or directory lrwxrwxrwx 1 root root 21 Dec 6 2015 /usr/bin/awk -> /etc/alternatives/awk Poky: ls: /bin/awk: No such file or directory lrwxrwxrwx 1 root root 19 Apr 20 22:59 /usr/bin/awk -----Original Message----- From: Josh Triplett [mailto:josh@joshtriplett.org] Sent: Friday, April 21, 2017 11:48 AM To: Kushwaha, Priyalee Cc: paulmck@linux.vnet.ibm.com; shuah@kernel.org; linux-kernel@vger.kernel.org; linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushwaha@intel.com wrote: > From: Priyalee Kushwaha > > Most OS distribution have awk in /usr/bin not in /bin Without this > patch, kernel-devsrc fails to build as runtime dependency for > srcu-cbmc script /bin/awk is not found. > > Signed-off-by: Kushwaha, Priyalee For anyone that has it in /bin/awk, does it have a compatibility symlink from /usr/bin/awk (or vice versa), or not? If not, then this would break the build for those folks. We could just drop the shebang and the executable bit, and run "awk -f modify_srcu.awk" from whatever script invokes this. > tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > index 8ff8904..c9e8bc5 100755 > --- > a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu. > +++ awk > @@ -1,4 +1,4 @@ > -#!/bin/awk -f > +#!/usr/bin/awk -f > > # Modify SRCU for formal verification. The first argument should be > srcu.h and # the second should be srcu.c. Outputs modified srcu.h and > srcu.c into the > -- > 2.10.0 >