Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426175AbdDUV5S (ORCPT ); Fri, 21 Apr 2017 17:57:18 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:35693 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1426159AbdDUV5M (ORCPT ); Fri, 21 Apr 2017 17:57:12 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] cgroup: define empty cftype structure for !CONFIG_CGROUPS To: Arnd Bergmann References: <20170421214206.1825504-1-arnd@arndb.de> CC: Paolo Valente , Tejun Heo , "Li Zefan" , Johannes Weiner , Daniel Mack , Ingo Molnar , , From: Jens Axboe Message-ID: <87094d9f-c6eb-567c-74d9-ff00e4ae5b3c@fb.com> Date: Fri, 21 Apr 2017 15:56:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170421214206.1825504-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: MWHPR08CA0010.namprd08.prod.outlook.com (10.174.103.151) To DM5PR15MB1195.namprd15.prod.outlook.com (10.173.209.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c68f49c-3486-40dd-3ed7-08d489014db5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;3:Po9HObV/hZn5cC73AVFKnf7KSRSF40vyOUzZxYaSKEWRNPqRVQcAYQBytL//M4sDR+iKcHFCZO1oX7WOejmBqjxDirZl+hXO8CcS4yzXZyZDgg3ZiGcp+vdoIigteH7V5eNmmUoHR4TcGSTscnFlpX7zMmA59sEkawPrnhZtwhGKs3Eyo1plQe5bpN7qo4zfqm5wxbA7cJSKOs2FIwPdc3Sth2nrJkRMYPGpP4iKPW+q9HWePW+ivGu6awQtYpkVtygiorJALvs0AAHRBB2NjbFdbXdEA9IN2q8za76x9X5cV9zd2SrpXSzvcje9qq9T5N9lK5KTQfJaErsozEqcBA==;25:CI6eO5kBRTmVlQ/et/8jDIZeFJ5j4Qmh9E/oSz+EGxCoTkSRRThnLfXu/8H1kUe1/XVSb2B+IWlMYZaKJHv8sfaHnnFwVuFbQ1prLv8/kxIWPHUOYg3WyZIbScRwDLBkTJok2YCx1Dea3qsCLTBv7qz+LGnjRIWCtn8B2tFcj5wvaMuK8v+DYSMWHJWib9qT+xnCBh8V0bcaq2qWxPPe8v26EC13LpQIaTEi77n9bcx7u9lAckXiOYw2aBBIWEza3CkAbr54IloiyfUTbzhebddS3qz6E+npFmI3eQAjvJ9w8dPqXmde2FXPyVv7I47cJkmj9/AO11GYTrD1i585qAQEtOWMC7hM2tTyoyuGEKwGP8wJHM7RAgJExHA/lkcE5OGWzodsK404tGDoTitmaOS6WNDgXY2Wgpz8ZmeJqaWeA3aUY85Wajl8Byznzuo0t3XYdzXwZVd0t9SGbw7Qlw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;31:3yybCjWBStD72L4UIfBFg4wuzA3nl/S3FUIdeYTyCtrEeznSzI7jj1VNJ9k26PpIi4tJ4+cEXp4lwRKQZnaUcWZOlP0wvFmDECoe4C6VP5k5wO8Twn1BgfHnGkZIGx88UENxYNMrLOuyUknqSSVuxL1hPvZUV6Uaf/joaL9Q3Yazs+aMG/c2tKCk/9pBg/UvsebgxCp8abF6BbWtMKVrE0J6WOpz0dY8ZJIHg8lxnGsC7oXDCp+55ciTbJRf6KTRdIx3dWm7IbSFxLqwd1Qrtg==;20:x9OFF33k6d5byMJ8VI6oIB8Yo7NR2QjYskHk6oFh04iW6PTv0GRuPqOZ8V1bd3OyLCH79gvAMVpT2oY0MJD4/sxU/NM7JjhorrbRYQubRyEC2l2e7CU5aUELzGQGp4cM3FdddTlt30Kr7xpyh8qP4JfS1k406uezh9CjXKfs8DEem02s8D+ft0r5QbA07VyPlQuNVuWIo1G7jSfm0qTFwy6X6ahuMqnlMohng2Hrbfci18/Js1HCtGcTG3VcSyhTVR3iA32/euazXRi6oX5k1RHwdRcnM3Vhi6VuC46jsK7p+Sh/ndy8bDnGAUqKfWeL2C81g6CYBhtH44yDoAbZ+YfPBfQX9w8DQLZ/Hwi/USQBGG8gmlfxK+d6m6rsTPH+e8U2O8F5eZRyWUEeeYLf5/+EK+0RaGqvipBjGLp8txUU9UGHBA/sDqlo6XYDKLTvIEzawMNX7bng6Hcawsa4kgs1kx3VtRdxk2fSUa8rtDGIA7z2nc4xAUxphjM5l7vx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(6072148);SRVR:DM5PR15MB1195;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;4:+VduM9bgYDpyqaSkYmGph9ZPhGZk7jcr4aDUCt5xTEsHjl89qutjzsv7Y6//E1cC0okLBWPDoEY41mbcISFW5alSWNkSLP/cNzWAddOZbttnSfrlDWVynN5WZVlTdpCWzkSY0agfdt28wXTrL/AgIK0ClppCgap9pGgEyvFR5sKKBKA3u098qzCK7l5rYUr8OSiDEIBD9cym4f5Vs2ivQRblp10aP65EsbZJKEcXoSw1LNHZgppCdCL3mtFcIdXLIh8zQRktSj4yJYieDv928IZ0f6pZkUZFHN2Xv1mIGQJm30D3W8WnqXiCBTWaZQCZRKE2zBwajwRCYzGO3XMgBgevsEErpzVM2y7NOBpkcWWmWwTM9ADfDa5HObIqf4qEc4uW4ZjisAkCufWZHXz85OnVli/lUq1ceGcE6qV/fHK/pd7zcT4b3rjO5QISWbxe8mM1Joxkjls/f+uyRkVsMfme1in6tSnoKbHL+/D8HodxpMi+RWBU4XHO02Dardj/JBP9xZ1A/P9o92ejdFcKuMkwNqhMtWxh1cOqQVwtJkMAMBRL1J9y7SBtAHXuWhgBndYlca40jOXNC6RtBiQqv2WkXCJ19PBQrwxXvx3xvf2jWBqsqElsro7PuoVSK3fOfwIxeinNpgvq0/ulgYt20NjTroLSCbYyFMOBY+Yy9neHV51c5TKhxDG6TmularzPaeLZa0CdSjVTP+/55rFvtw== X-Forefront-PRVS: 02843AA9E0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39840400002)(39850400002)(39450400003)(39410400002)(377454003)(24454002)(230700001)(6306002)(6246003)(4326008)(33646002)(31686004)(86362001)(6916009)(53936002)(966004)(6116002)(90366009)(25786009)(110136004)(3846002)(83506001)(53546009)(38730400002)(42186005)(66066001)(47776003)(54906002)(2950100002)(36756003)(5660300001)(2906002)(81166006)(6486002)(117156002)(4001350100001)(189998001)(77096006)(31696002)(23746002)(76176999)(7736002)(50986999)(54356999)(229853002)(6666003)(64126003)(305945005)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1195;H:[192.168.1.176];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1195;23:dypC0SSlb2UTo+cR0bTIXppXHRMDQfbbH8LV4?= =?Windows-1252?Q?2rNAQj/Q7nxH1jDgoc1dD8eSiCcsMKRgPQnZdGvbfoqv+ndIB4t3O81I?= =?Windows-1252?Q?PPGtmekG98h54/l1/VShPlB6HqBwtJrgfQ6f/DZRzrCej3GnVlq8OPKi?= =?Windows-1252?Q?hdvLXiyWL4Q4rfcgCeGECMbmPhhxLxnSzZ7aj6bnd5MtsmVU0OFSuTgh?= =?Windows-1252?Q?KugLSbcFOXlcU2XcOMprgjyPcxZfq/6ym+uCViR8ooiUFVES90HEF6Aj?= =?Windows-1252?Q?0aRK9/q2N6w0OdHN8xJLMPByRi0mi21upyhvyfKTTSb30xak5rfzIl2N?= =?Windows-1252?Q?XrhJobdTH7Cikl6Rt5M8xUbq+3GMkZ3vlxTNNchmDxozH9qGATkdM1c5?= =?Windows-1252?Q?8QsE92gHAlu+mT64+MFZwCdGFRuVX0ogyxuc4K/axGzdBZrxNc9Cw1PY?= =?Windows-1252?Q?lFLJkTiL37N2ICTd2alFflo5CDHQLLfSbS/+k/5DF2Ix9127V5GyFDTw?= =?Windows-1252?Q?3WtIbqVbqiBPfIugx+O3Noc7KCgspVModV77irKM7PnWyVZ2Xk+q7GLB?= =?Windows-1252?Q?cWWP7bnWFtk2qtfBuhLqSbNVJ9x+UIQ0VVBFZOS7Wws4OcuvCjkCeQcB?= =?Windows-1252?Q?M0R6SURaDegL7skqBd2NmrmUnwpU/O7Z+vSUt8IuXuWjfsXqYxtzbgI0?= =?Windows-1252?Q?0tis8R4LsC7ZHxTn9ugJQe5Lok4bJbrtrjGm1ndz2eVDRGlHm5RAzOvl?= =?Windows-1252?Q?iMlHyFgqXUwh9Cc6/JipzzTRX5EmhlthsVUsMG2QezfjWNN98g+UBpBL?= =?Windows-1252?Q?KcnIxHxkpTCjjPpLHx1S4CziNrebrWlbAZQTDqvxKibMxVq6XnVLp++l?= =?Windows-1252?Q?SehFm5snHNhNn8qOz5l63dXzY0AvwJRfoAFHFg8nascJsUYdyj+dfBEJ?= =?Windows-1252?Q?bI97JlboeOeoZzZnj8ooHQJAThOHjv/4NHIYwdfB1YiiHJMI16DcOpyW?= =?Windows-1252?Q?B6TKSfIm833j0TIq2gFbiQK619Mgo09oZfJuWX3XOzgJrcTO3Fz/gRHm?= =?Windows-1252?Q?sdIa8ScysAYsDtqj9dq7dMICZ9yChfO0bMg+IpSfg6BO4Nhh5lgmUlCO?= =?Windows-1252?Q?lL67Jrt4Ps7iexYd1V/2vizdKNWLaF0ighWjroo/Ug+YW8+YVITnDrvn?= =?Windows-1252?Q?JDjXRNH2j+SMUQlO54469LrYSbqXPbCch/2s5Z5ib7+gw0ZPN6Dw2PA0?= =?Windows-1252?Q?c58tFDL/jSslUGJDNTcSsjYWQ1nMmwTVMpJkxjGQOVymfyZAGqdYVzqO?= =?Windows-1252?Q?9pIfmcApnoD8bu3/2g68qAkEYx/92oeEKtWP54pS6U2iFCWYVW4e1/jQ?= =?Windows-1252?Q?PNkL+wItUQj4Xq4IIuzT8eFP8Y4tNcs2A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;6:8zCSjLigEV0dV+G+g3L7jr/HXnXFqcl+2xS7zPb6EudeKhR24RTFMEn6EZ+mE53AndfBChn/F02wbA5NmZWYdbU0tg8GCasGPTByuZJ3F8/yftfkXw9pQY7ieEPqgUxWFGGUmpwlvM5QD9ge961hHva/Yli36cjAJ3OCgjaQf8Kr+VnoEfYTE4d4sqY3KjcWm6IYP3Ge+vVxfKo97ss61eGJLqj87cNkEyX5RmZQ86i5wnXgawf9Tjh/vzZoup5+8MG5XJVY4aBm5ErL53Ktv018i3oBWBvDze44hI95T7QRZcGT7Yzr6hWAewDTWfYgfKS5VdbasH/2NP0keOzi6OGg+xPZDfuBhLoKYXmrbiBYlEHngr65thCCWBq1dXK9TaDr36LARVXbV+zMPL9elD40OHm8OD74C85Yc6Oyi26dRTpnQyCzE8G08y/bOxQ/QvZHxPsqWCS8jMntQ/xwMifVk7rGSqj76VYXc17hNJu8395+oOphm+7mt8zbJopomyhG+79y/6Cx5rCj2GlzLw==;5:tc6HQm1t5fQ18OF5U3ihWOv0fSGI36daDJeQ7zpxKaM4JTNzGZNBhc2076UC7UX9wkB9EYTpJLfd9zfPzV35zjMPoKcktmeNx0It/IonwBJFdKpqyeRkTBP3dRDpUvt8rO1eqnnm19YS04ZDWhHjcg==;24:1b6Sk3SNXK/nbzst+t7fkeeCxoRUQn8U5FZ8rJDwbakqHfiaIGTukDZOLBcjdUGsuQZosZk2pIYZcrednnsmhM9GjESiN1y6nIFhOoABwro= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;7:P7mPvF3K/Ou8sxoZAfZlKKYAgZS6hs8eIK1phUW+8keZ6iX2QurkgDMFnQEHLbqODR801EtoX3rH/OWeRW1qZOa2UN/ISDw+vpFGULrBquH2OsFkJ8Z8O7hy7PtRFFEnrhhr59SvlN8u91qFKrxGuuof6yjCCzgVoXszUZYwgBt6DftCMlKh43NwwtkE470H03A0vDd93/X3a5Km7jGSTW0ksSguokSBVi2btggg7SVxSlc3/Na/grRrwZUbofBXtez3uG0Qchs+7/d/DwGW3PtP82+3npYkIZqZ5ZkzaSzuZoTsbrf4Q4IT2Wu21X/fUiTMZ+A4dzpeVo2dEefVBw==;20:xb8GoK34dyr03tc4xX+65ig9RZXkp0jPQlRW98m9rBuqKk86lvgbfLAragRKHGuFoYNrVxhfAWFiW7ZYp9ezfh+juMvid8c39VDc0588zEgtoppRGK9VlkKQoliSPE6SCCBZxeLFMVLKMTr/nQXzhuvYsP8Wr8bEG2JmEuyUMV0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2017 21:56:43.5600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1195 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-21_17:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 17 On 04/21/2017 03:41 PM, Arnd Bergmann wrote: > There is a new forward declaration for two global cftype arrays, but > that fails to build when CONFIG_CGROUPS is disabled: > > In file included from /git/arm-soc/block/bfq-iosched.c:105:0: > block/bfq-iosched.h:820:22: error: array type has incomplete element type 'struct cftype' > extern struct cftype bfq_blkcg_legacy_files[]; > extern struct cftype bfq_blkg_files[]; > > This adds an empty definition for the type to make it build again. This was already fixed up yesterday: http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.12/block&id=659b3394eb67a5e274d7e7348633b508510a5c8f -- Jens Axboe