Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424510AbdDVB42 (ORCPT ); Fri, 21 Apr 2017 21:56:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59154 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423424AbdDVB40 (ORCPT ); Fri, 21 Apr 2017 21:56:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D09DF60DA5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 21 Apr 2017 18:56:24 -0700 From: Stephen Boyd To: Arnd Bergmann Cc: Tero Kristo , Michael Turquette , Tony Lindgren , Richard Watts , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4 Message-ID: <20170422015624.GY7065@codeaurora.org> References: <20170419214318.1605787-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419214318.1605787-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 23 On 04/19, Arnd Bergmann wrote: > When none of the OMAP4-generation SoCs are enabled, we run into a link > error for am43xx/am43xx: > > drivers/clk/ti/dpll.o: In function `of_ti_am3_dpll_x2_setup': > dpll.c:(.init.text+0xd8): undefined reference to `clkhwops_omap4_dpllmx' > > This is easily fixed by adding another #ifdef. > > While looking at the code, I also spotted another problem with the > assignment of hw_ops variable that is not used again later. I'm > changing this to setting clk_hw->ops instead, which I guess is what > was intended here. > > Fixes: 0565fb168d63 ("clk: ti: dpll: move omap3 DPLL functionality to clock driver") > Signed-off-by: Arnd Bergmann > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project