Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1041281AbdDVFiv (ORCPT ); Sat, 22 Apr 2017 01:38:51 -0400 Received: from ozlabs.org ([103.22.144.67]:51919 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1040866AbdDVFit (ORCPT ); Sat, 22 Apr 2017 01:38:49 -0400 From: Michael Ellerman To: Shuah Khan , shuah@kernel.org, bamvor.zhangjian@linaro.org, benh@kernel.crashing.org, paulus@samba.org, dvhart@infradead.org Cc: Shuah Khan , viro@zeniv.linux.org.uk, emilio.lopez@collabora.co.uk, mingo@kernel.org, luto@kernel.org, dave.hansen@linux.intel.com, dsafonov@virtuozzo.com, rkrcmar@redhat.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean In-Reply-To: References: User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Sat, 22 Apr 2017 15:38:46 +1000 Message-ID: <87zif9ypax.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 23 Shuah Khan writes: > Define CLEAN macro to allow Makefiles to override common clean target > in lib.mk. This will help fix the following failures: > > warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan Should probably have: Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target") In hindsight I'm not sure moving the clean target into lib.mk was the best idea, but anyway it's a bit late to change our mind on that. This patch is a good solution to fix the warnings. Acked-by: Michael Ellerman cheers