Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1042012AbdDVGpH (ORCPT ); Sat, 22 Apr 2017 02:45:07 -0400 Received: from mail-bl2nam02on0088.outbound.protection.outlook.com ([104.47.38.88]:35168 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1041635AbdDVGpC (ORCPT ); Sat, 22 Apr 2017 02:45:02 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=fail action=none header.from=nxp.com; From: =?UTF-8?q?Horia=20Geant=C4=83?= To: , Roy Pledge CC: , , Haiying Wang , Ioana Radulescu , Stuart Yoder Subject: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Date: Sat, 22 Apr 2017 09:44:49 +0300 Message-ID: <20170422064449.25498-1-horia.geanta@nxp.com> X-Mailer: git-send-email 2.12.0.264.gd6db3f216544 In-Reply-To: <20170421144734.7nr2dnqcltgov74v@mwanda> References: <20170421144734.7nr2dnqcltgov74v@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131373171002908005;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39840400002)(39410400002)(39400400002)(39850400002)(39450400003)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(6666003)(6636002)(2950100002)(104016004)(23676002)(5660300001)(47776003)(356003)(5820100001)(4326008)(39060400002)(85426001)(77096006)(81166006)(8936002)(38730400002)(50466002)(106466001)(189998001)(1076002)(2906002)(50986999)(76176999)(8676002)(8656002)(36756003)(53936002)(54906002)(305945005)(105606002)(86362001)(50226002)(2870700001)(33646002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0301MB0597;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD040;1:wFvzbWQ/pWLKxoyANECLh+K6YlP2X23RshYDT9AWQgB8xjG0j/029lcU7ydaCvT2ZJxlQUlHWLnazwimeviZL52OWRJBZW+PlOSd50x4hSkIDjBx07xKPJxa8eo6F43XIYT73t+MlIlmc0xb7E0m0Ipv7Msm9NgsclQMEnnW3CBDO4kyuAbwGHtEOMrQKSF4TtrJrSpqSQRF1Cz/pnS9zO6vz5F2RnwdjRDRKUoAjKP7GgTbpqqa+lhYEsXRF/987q/bUqKpc3t6Bsp4NWA/g4AVucoBFpMuNMG99dkzIPSah3+CD8AzEl+3HyRK9rHetyOVALkLwH5ofgjVB4O3mk2UOoAR3oHL5gJ+ZrzuqH6EIkXGbnUWGPP+Z1KmEaBWhfiQalr6ztkfhoDYaG4U2ap/Od8O0lyaCEkVknMQt9fAtoQMnxIMD20HmTyOgmmN8cOb0TikO2Fyoxg0vUSp+TGZ18p79ZE/tale925dlRb9sSa64eIWAZY0yNCzuRel5gPmLxfbl+47X1J1i0k+T6CPkgpog4JPhMhY9IazLglBWsHsa35F21L6x6ItJ6GICF/3Pa+qN1ezWdCmy4CKIYvutfCJfP9XVSQLsXYKaJxt4HEWLf8I2tecST1VSVKQ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97b4bd71-4fcb-4b4e-bc09-08d4894b1919 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BY2PR0301MB0597; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0597;3:h/Opxk67Mxn+T5SjCEQr53qQjYoAICo+kvKq3h6/0w+sjb606SwbxkFovcauUgwQFeXvqQPgE+1SFZFxGRkCvOeZyYV7pdGESHfRqnmKjp+U37STpFTKwJorRd68JTDn8qEIGpmUPxThFd6eEve7nwzOqi252ywX0udK+TD4XK+r5yqTYJLRUrWCFRmnT7or/JuOBn7lozxblLDP4bApwJGbl/OMYDhTvl5oH9zLV7uhJqS7NVSoe1ibJWWTS9bH1iqoc1WISD8q+3ex0J5V4c8UyNTnfnAmZMeuXZLw32S8bdLHyKpYnePZe2+MrX4OgwJOzGkCK0oo4sXfWVJdM4HzMzxTgXJ6OPk4p4oEdjUGuS3wENZJQEl7/Cs6i/NumznqRp3w/YmFSswW5MjHJ0SGHKfMnFT2FtePdPFj//iXR06lPcUZMD/nxM/IzJ0e;25:AlV4U+jfKTfrhsmwVNmnbJ3ENlEvm6azus04I8SC8ATByPfuaa/R3elISlGHM3VCUyoTGkTqG+hR3VhV8RVhnVMP+OQujU3UyWFEvdnhLm41220qWf0q1Moo/fjUGr+QmY96dj7O640fVgaPXsWlKIBY71zvkdhcqJgAoorXOS1PvAlBzmTCwYMLOgx4zvwHelwWjXFEB98fgRjuSa0r58/fGRTe9i3i6SUOkvbIG5KO1BquaEVLbHYAqmmJ0bQ56xeyOrl0MwtOHD9jpr591fvM4zJi0Hl1V9OSRcsoVGo1KxyxwLZMUjiDS969IC01Rv224cPYe69aPMyB1OrHAvX1SzT8LA7T0pYRV7GcEpy5bTmAZDKnilBES+rjZLBxA3R19uLwVsB7qAW+LkeXDEr4Pjuublt645WzdHZbAdHxAn0OBfVD7e5VuWvBWb8jHMqoWVNVImHbfMALm5J3qQ== X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0597;31:7BBRrwYU7c0u9jCAd0tiSgkVR3/NACpEy1glcwAegSrWRsSMBS32yElHVlvfN5EKfBJJRmGS7rVWkI6IeGEcwc94/m4ahhItidLLsoZRRPOfBLNEwQdvSxmdladYcsG88RHhVYEu4lAC2MAkm25SAh5z3A3xlRNiFRkLuPCurF0SUwrt8iuADUMZON4Nhby5zZ6USuCH7/Qo8WefYIJLql7386adczwekf9evWN7UzF/V/3EXV6oNHXAuP/+0HwooAnWfXsWg26k/PW096VpNQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13023025)(13018025)(13024025)(8121501046)(13017025)(13015025)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(20161123565025)(20161123556025)(20161123563025)(20161123561025);SRVR:BY2PR0301MB0597;BCL:0;PCL:0;RULEID:(400006);SRVR:BY2PR0301MB0597; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0597;4:ozBFQaYlXTVHGA7RUD6/rQBf/kpUkeRj6j6//hitS9DAgWW93MWF5hhgJ7DSxCvgW7ionP06BuIWOf/Shy40hgaE5iD6cTAKXRaR42uFYtuw+3Ta5zl9rufs+YmwJ4XTf9/SSBscPaTHGkw6yUmIAD0mRNHT2O/SYhwPIRDlNgM6FQh51gAyZw1ee1yVNoRHBHFf2qMnS2cqn4iC+6k8dfeLrnWva1TKndUMf7lRldDioprVY/ZcQdk1JQguGlgiA1FiOGaFH4q6zv3fgagI+5RRlwTaFLY3nh0Dk3sMoZWQE6rvdAC5vrI6LPeKABb2dpOLdxzzpnlZoT+NCW9uP0OcWEaazv4D2NgCUIbhTAQWqMtlAOwMeeBJ9aNOHONioghnCI6owLkU9yUOQa/IAsaa3qlYA2aDPU+8OzARsF9M9/t9Q0g4DXtByaXyD6q5cqJ7bEW6ssWNPYo91vrGgt14PpZBT+D76FGx5Jf6LPLOB+pnuPRoaJlFmjqQjx+W1bGokAiSBb/Hi1gqsBdSXrUhayiyV46VnFvvx7Y5xkGR3z0wp/2wIHH/NhkILy5jpd9UrpdypQ4lkSvQhyuA2C5uJpX5zeIuNLp/eDE3FWcH8uQxlm/KGLIYQmKih2mfJA0FVoFEx7NjzAsvBdS7/Xu+XiPZJljA7eJZLXlAPvGjnlMtp1+HaQM5ZbpNHcRqgm677XEG78axRnRUuXhjyLvlvyAQefi871udjsm7wNNRY34njFM4NHCol13/MfwsoouYfF6zcR8mc1aVkeTKbuJiEH1NQSooKlX2QTSc9hU1jS6fpXZAKOPJ13Zuwo6kg1XxT5ujfRHR/MsqKyWQ5u2yjOF5QwQkyImVjBtv23ce4WrJpR0zpNU6QIrKgFisnQeNjzSNKLcu9XI8ZhdrnLG/R4BHkOD5ae8Y956rOlo= X-Forefront-PRVS: 0285201563 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAzMDFNQjA1OTc7MjM6UEZLSHJOaURvVlQvRFMxK1NBZHVQbE95?= =?utf-8?B?NDNHck1hWDA0MS93UWpTTDRtV2FLRDZnRkpCQ21HT0tuR01DcWk1VU1CZGpk?= =?utf-8?B?ZHA0d3hNOEJZalc1Zk5nUENzV0hmMWNyaWpGYmFkdHNWZDRZbFRhUlNJSUg3?= =?utf-8?B?bmVVZVJsamh5L2JRRVZRWUVpcUQ2eWx2WFZGdzlTOE1ueENVSXl1RDI0a3Ri?= =?utf-8?B?YUJZYVZnQ1NXbWRYZU44M0JsOXRweUtVeklVOU4zdjV6dUt3bWQyRTY0SHdw?= =?utf-8?B?WmRNWTJXS045blRRd0thOU1rSTJ1ZEw1clNVS2VZVzJWQ3VwQldWdTY0YlRH?= =?utf-8?B?NTBMV2txTnJRcUJDSkRha0VUZVdlQ2NVQkVxVDdicjY0VXJJMmZqaUpidWhj?= =?utf-8?B?MEw3cytaYisxbEJFTDc3b211a21NUFVTenB5MmVkUGJzcGZ2aFJUVHI3cFNY?= =?utf-8?B?clVla1ZkZzJSaURnd2cvQ0xDQlpqdFVFTDZ0UzFZdGVPMWUxOW9oNE00Znk0?= =?utf-8?B?aHN1d08zK1M1K2d0M0I2UDRhMHBFWnhLU2tjbGlkYWZDRHVoUnNycEdZN3l1?= =?utf-8?B?Q1NLSUVLajNLVU9JS21iQkpJK1ZTOUZVZFFGcFVYd3dRUXUrMjFNVXdhMitP?= =?utf-8?B?RW80NWlMd0w2ZDAzQk5sUzcyeHJUdjdWazlOTHdud0VxSUFwUnBHK1JHSGtK?= =?utf-8?B?MVcxTitRQSswS1ZBSmFuYy96enRWTDhzelpSUXVXdzFOWjVxQm8yNHVQUWFp?= =?utf-8?B?Q0JGV29nbE94LzhOSEhnRjc5NXlHaVR4ZHp2NmhOTWpaa1NVMXBtK2tZWG95?= =?utf-8?B?aVd1N2gyVTkvWXBObjAwQVppUDZrZkcxVUpQU0ljWllZckwwdFVhREhqOHhZ?= =?utf-8?B?NVV4cW9xSmhYWVgzREF4UTNEaEl3ZGZCNkhzdnowYVV2ckNkRWlIeFgrOUFo?= =?utf-8?B?b0hHMXo5Z1J2dktVc0h3aG5LaFR4VDFXWmVIMmdKRDQrNytyMVphMVRrWnBZ?= =?utf-8?B?VkNOVDRVVkdyWVljVnp1YkREbEo0YldCOW1vUlZSSUxoUEhOUVZxN1ZJL3BI?= =?utf-8?B?Uk5XOFRwelJsM0x0eVBUUWtVMVZya1RnRnE5cVAyV3gydkl5OVh1TmZYL3lp?= =?utf-8?B?VDhGQTJmTWsxOC91WUNsMWJMS3dMdjJTSGhMZmxHUDNQUm1pcDNkRitNUEp6?= =?utf-8?B?WW16SURuZ1kxVUloY1VkeTdSUjB1U1duU0VkaTA3UitiamJ6WlJKT3VOOUhs?= =?utf-8?B?M1lxWEExMDQ1bS8rWk9jNmlyL2JzQVVESzdOTnA1WFFRYXZNTkRtNEhvNzNO?= =?utf-8?B?ODZ5dHk4K0pUcSt3WmVpYVlUK1BKcXpwUlNtcWdmVmhOaEdZOFRGWVJSOTM5?= =?utf-8?B?RlQxYmZIdnhuNFFuSWVFZnYvRzJpeFlTM2tSOSszNzZ3b0hjQnVhN3doZUhk?= =?utf-8?B?SHlldkFwTWl2bGNnNnloUHQyU2JWQW8zb0plOG1OTnBoQU8rQ2RoK3VOLzVi?= =?utf-8?B?WmhJU3B3Vy8wdzJuSkRuY2hydkFoZlF0NWxjb1Z6eGd5dkloL0VyYW96anly?= =?utf-8?B?UHBxZTZMVzBnRTRjeFlRMDZtQ1hBWlJ0TXJFbEhJdTE0cUhxSWYrRmxneTZN?= =?utf-8?B?VTBVTkJvZ0NIeG9NNGQzWG1wUEVDQkZlQ2JaeTZZdnk2Mzl1MlBVSFl1RzRB?= =?utf-8?Q?nQ+O4Y/vuXeJH6EuWJk4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0597;6:fAaS+IlYN2ALssaDIrQrj/vMRzdJMwbCVJoDv0NZbFqFJlRUuKZGtMGalVx9knVOh7RRRbelJj9BGjj0cS4LkpD5H1fnHDjmGLWOjDHQoMdf/E/xLQril+qPaTgYuMKAqUxzwl7kAD3Pj+shI28y5WOhTKgBeZhUour+WT65nEidH8GiVJskFnF6utNdtA718AGDcUQ792+hOZXpWukxNsT50M3zhp7Fdk9AIJyRGv/+DR7uyTCX8U3LcVgEn1BURorIQy4nsIB82/aFViNRReKVxJArck7za8szC0hMrBe2W8wRE6PMjeJnxzKvd3OU/lWtBP6TFehE2xsvgTYXI/fWksE4yWQ6dG++kutr+0v+a6icXBpm7V9v3NvnURtkUj9IUZ9lcri2idxmxp6d03hiq1jW/OjFIALQfieitgNg8sUKvBGkY4aDLRQFrqlI7J4ckSzegdKdP5njB1+h9EcCz9aklWcnm0zZVNoVLg8st+BJHf7ZpX/sxIowZe5aJVKsH3QySCgrFKQ9a0jjyw==;5:TfpgQgEav2Me0r7P5/OGB2o8Mr57FIPz6Hv3eVF+YBAZuJ015uZEgyYrFYP8jF2RWYm4wn5JuP2gOhhHAtY6bu03VcCXbWFYdGAOR9V6YZO08XNZnrhK42ora0v9uYebVZIMCUaTFZi8jfnoVn6F13p7O5LlT37U9prR/ttsSK6YocljtYgxeu/aaKzc0vHP;24:sXPZHrlHOKXFtD8FO5wm93J4o/whiNlIPCLCwO8i++hD74/fklWxmG3XgPNcs/qURChszkDfTtoPTpyAAQt1AsVtW+lDKSEG5uITztk7GyE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0597;7:hwO9H2XPAGxTKXf4D+EycUCVDFOBPLgBYv9NWxLEAQw7TNBLZu0vtR54ce/JdUURbb2/QsSyNUMLM6lon827Z4kPlyG/4EbGT5gIPboZQsuCIUy3MDoszOHztGawgZUN8kDPblwDz02FNmopmXrYT+VkoXjMR/odRr2NGoatukiPdTSGKYF6SU4ta4YRb3moPRDnE5v3W2BRhFx3pM9MXd9zupBGlTDEnSzMjUM4piDPstyxoMVpJbcIeIVXVpcMlZuUTZn8+3Tiie3gKRbE84bM0wjS9gNlKb3EMzY/jZY3SvbRlXD3iTyFDWUnHAswx835wTj9ThWLJ8+ADbw/BQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2017 06:45:00.0412 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0597 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 27 When checking the response verb, the valid bit should be masked out, since its value flips depending on what Response Register (RR0 /RR1) it's been read from. Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2") Signed-off-by: Horia Geantă --- v2: use QBMAN_RESULT_MASK instead of hard-coded mask drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c index 2a3ea29d9b43..7988612aaecf 100644 --- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c +++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c @@ -963,7 +963,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid, } /* Decode the outcome */ - WARN_ON(r->verb != alt_fq_verb); + WARN_ON((r->verb & QBMAN_RESULT_MASK) != alt_fq_verb); /* Determine success or failure */ if (unlikely(r->rslt != QBMAN_MC_RSLT_OK)) { -- 2.12.0.264.gd6db3f216544