Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423230AbdDVMIW (ORCPT ); Sat, 22 Apr 2017 08:08:22 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36214 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423134AbdDVMIU (ORCPT ); Sat, 22 Apr 2017 08:08:20 -0400 MIME-Version: 1.0 In-Reply-To: <20170422015820.GZ7065@codeaurora.org> References: <20170419174507.4055014-1-arnd@arndb.de> <7f0c996e-df53-ffb7-2c02-2f7fa66d2b94@ti.com> <20170422015820.GZ7065@codeaurora.org> From: Arnd Bergmann Date: Sat, 22 Apr 2017 14:08:19 +0200 X-Google-Sender-Auth: zj_WIpWM-jPm-Oxc63MH6QatRJo Message-ID: Subject: Re: [PATCH 1/2] clk: ti: divider: try to fix ti_clk_register_divider To: Stephen Boyd Cc: Tero Kristo , Michael Turquette , Tony Lindgren , Keerthy , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 26 On Sat, Apr 22, 2017 at 3:58 AM, Stephen Boyd wrote: > On 04/20, Tero Kristo wrote: >> On 19/04/17 20:44, Arnd Bergmann wrote: >> The failing piece of code is only executed for legacy boot mode >> OMAP3 right now, which could be potentially stripped out of the >> kernel already (I think Tony removed the support for non-DT boot >> OMAP3 boards already...?) This explains why I didn't notice the >> issue in my local testing either. >> >> > >> >Fixes: d96f774b2538 ("clk: ti: divider: add support for legacy divider init") >> >Signed-off-by: Arnd Bergmann >> >> So, this patch itself is fine, but the desc should be updated to >> reflect the above somehow. >> >> And the "Fixes:" line should be updated to point to the commit >> mentioned above also. >> > > Waiting for Arnd to agree. I can also rename reg_setup to reg. Yes, it would be great if you could update the patch description that way so I don't have to send a new version. Thanks, Arnd