Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425268AbdDVP0S (ORCPT ); Sat, 22 Apr 2017 11:26:18 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35530 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425012AbdDVP0O (ORCPT ); Sat, 22 Apr 2017 11:26:14 -0400 From: Eric Curtin To: thomas.petazzoni@free-electrons.com, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Eric Curtin Subject: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc. Date: Sat, 22 Apr 2017 16:26:09 +0100 Message-Id: <1492874769-14446-1-git-send-email-ericcurtin17@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3510 Lines: 70 checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that. Signed-off-by: Eric Curtin --- drivers/staging/fbtft/fbtft-bus.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index ec45043..3143050 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \ buf[i] = (type)va_arg(args, unsigned int); \ } \ va_end(args); \ - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \ + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, \ + par, \ + par->info->device, \ + type, \ + buf, \ + len, \ + "%s: ", \ + __func__); \ } \ \ va_start(args, len); \ @@ -41,7 +48,10 @@ void func(struct fbtft_par *par, int len, ...) \ ret = par->fbtftops.write(par, par->buf, sizeof(type) + offset); \ if (ret < 0) { \ va_end(args); \ - dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \ + dev_err(par->info->device, \ + "%s: write() failed and returned %d\n", \ + __func__, \ + ret); \ return; \ } \ len--; \ @@ -60,17 +70,20 @@ void func(struct fbtft_par *par, int len, ...) \ len * (sizeof(type) + offset)); \ if (ret < 0) { \ va_end(args); \ - dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \ + dev_err(par->info->device, \ + "%s: write() failed and returned %d\n", \ + __func__, \ + ret); \ return; \ } \ } \ va_end(args); \ } \ -EXPORT_SYMBOL(func); +EXPORT_SYMBOL(func) -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) -define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ); +define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16); +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, ); void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...) { -- 2.7.4