Date: Sat, 22 Apr 2017 17:31:27 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
To: Florian Fainelli <f.fainelli@gmail.com>
cc: linux-kernel@vger.kernel.org, <arnd@arndb.de>,
        <maksim.salau@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Mosberger <davidm@egauge.net>, Roger Quadros <rogerq@ti.com>,
        Wolfram Sang <wsa-dev@sang-engineering.com>,
        Oliver Neukum <oneukum@suse.com>, Jaejoong Kim <climbbb.kim@gmail.com>,
        "open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: core: Warn if an URB's transfer_buffer is on stack
In-Reply-To: <20170422183744.11149-1-f.fainelli@gmail.com>
Message-ID: <Pine.LNX.4.44L0.1704221728230.31762-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1497
Lines: 42

On Sat, 22 Apr 2017, Florian Fainelli wrote:

> We see a large number of fixes to several drivers to remove the usage of
> on-stack buffers feeding into USB transfer functions. Make it easier to spot
> the offenders by adding a warning in usb_start_wait_urb() for
> urb->transfer_buffer to be located on the stack.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/usb/core/message.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 2184ef40a82a..abefddbe9243 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -8,6 +8,7 @@
>  #include <linux/pci.h>	/* for scatterlist macros */
>  #include <linux/usb.h>
>  #include <linux/module.h>
> +#include <linux/sched/task_stack.h> /* for object_is_on_stack */
>  #include <linux/slab.h>
>  #include <linux/mm.h>
>  #include <linux/timer.h>
> @@ -50,6 +51,8 @@ static int usb_start_wait_urb(struct urb *urb, int timeout, int *actual_length)
>  	unsigned long expire;
>  	int retval;
>  
> +	WARN_ON(object_is_on_stack(urb->transfer_buffer));
> +
>  	init_completion(&ctx.done);
>  	urb->context = &ctx;
>  	urb->actual_length = 0;

Does this really help?  I mean, don't we already get warnings when 
the host controller drivers try to map on-stack buffers for DMA?

The only difference is that one wouldn't have to read as far back into
the stack trace.  But that hardly seems like an important
consideration.

Alan Stern