Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1044945AbdDWKdc (ORCPT ); Sun, 23 Apr 2017 06:33:32 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:28246 "EHLO mx-out02.mykolab.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1044876AbdDWKdT (ORCPT ); Sun, 23 Apr 2017 06:33:19 -0400 X-Spam-Flag: NO X-Spam-Score: -2.9 From: Federico Vaga To: Steven Rostedt Cc: LKML , Federico Vaga Subject: [PATCH 4/5] trace-cmd: fix argument parsing minor BUG Date: Sun, 23 Apr 2017 12:22:57 +0200 Message-Id: <20170423102258.21609-5-federico.vaga@vaga.pv.it> In-Reply-To: <20170423102258.21609-1-federico.vaga@vaga.pv.it> References: <20170423102258.21609-1-federico.vaga@vaga.pv.it> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 32 For some reason the list command does not use anymore `getopt()` to parse the arguments, instead it uses a custum implementation. During this change [5da0eff trace-cmd: Add regex for listing of events] the variable `optind` has been forgotten. To reproduce the problem try to use invalid arguments. The application will not report the correct invalid argument $ ./trace-cmd list -a list: invalid option -- 'i' Signed-off-by: Federico Vaga --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-cmd.c b/trace-cmd.c index 1a62faa..a05df92 100644 --- a/trace-cmd.c +++ b/trace-cmd.c @@ -706,7 +706,7 @@ int main (int argc, char **argv) break; default: fprintf(stderr, "list: invalid option -- '%c'\n", - argv[optind][1]); + argv[i][1]); usage(argv); } } -- 2.9.3