Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1045241AbdDWMSW (ORCPT ); Sun, 23 Apr 2017 08:18:22 -0400 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:47169 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1045205AbdDWMSS (ORCPT ); Sun, 23 Apr 2017 08:18:18 -0400 Subject: Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() To: SF Markus Elfring , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Dan Williams , Javier Martinez Canillas , Krzysztof Kozlowski , Kukjin Kim , LKML , kernel-janitors@vger.kernel.org References: <930f0a6c-bc5c-3d01-6814-563780fc90ef@users.sourceforge.net> <9c10b823-f49b-8c73-2bf8-0fd2b0ba0231@users.sourceforge.net> <02134825-fec7-73d7-2eb6-b510eaaf3b08@users.sourceforge.net> <49f1c0b2-7463-2121-1aed-0998f6635c92@math.uni-bielefeld.de> From: Tobias Jakobi Message-ID: Date: Sun, 23 Apr 2017 14:18:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 48 SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the sentence for the multiplication information inappropriate > (or incomplete) at the moment? I already explained that. It's a 1:1 translation of a german sentence into English. A native speaker does not write or speak like that. If in doubt, don't use long sentences (with nesting, etc.) at all, and break things down into logical blocks. >> Another sentence explaining why this is bad/undesirable. > > Which details do you miss here? Pretty much everything. >> In this case, the output of the checkpatch script would come in handy. > > Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other > search pattern so far. > > * Do you find it worthwhile to add a prefix like “devm_” to the used > regular expression? > > * Would like to improve any related scripts for the semantic patch language > (Coccinelle software) a bit more? I don't understand why you're asking this. I'm talking about the _output_ of checkpatch, not about the script itself. But undoubtedly your patch is motivated by the output of said tool. Hence you should mention that. - Tobias >> With this, you avoid cramming every information into one long and >> complicated sentence. > > Thanks for your feedback about other wording preferences. > > Regards, > Markus >