From: Jon Maloy <jon.maloy@ericsson.com>
To: Pan Bian <bianpan2016@163.com>, Ying Xue <ying.xue@windriver.com>,
        "David S. Miller" <davem@davemloft.net>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] tipc: check return value of nlmsg_new
Thread-Topic: [PATCH 1/1] tipc: check return value of nlmsg_new
Thread-Index: AQHSvACw8roJ2ioJzkObv8GPU8XZHKHS9AVQ
Date: Sun, 23 Apr 2017 13:33:09 +0000
Message-ID: <DB5PR0701MB1958A4384C0B9C0571BD1DF99A1C0@DB5PR0701MB1958.eurprd07.prod.outlook.com>
References: <1492931359-25004-1-git-send-email-bianpan2016@163.com>
In-Reply-To: <1492931359-25004-1-git-send-email-bianpan2016@163.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2017 13:33:09.1281
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0701MB1958
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsUyM2K7ja7M2j8RBpMbNC3afz1hs5hzvoXF
        4vKuOWwWxxaIWWw5n+XA6rF4xRRWjy0rbzJ57F7wmcnj8ya5AJYoLpuU1JzMstQifbsEroxr
        u14yFdzjqujZfYGtgfENRxcjJ4eEgInE22+9jF2MXBxCAusZJV5fv8gC4ZxglOh8+x7MYRHo
        ZZbYfPAeK0RmHpNEz/Hp7BDOc0aJa4f3sIMMYxPQkHg5rYMRxBYRKJA4O/cSM0gRs8BpRokd
        a/8xgSSEBewkbr96CjSXA6jIXuLU5giIeiOJxW8egfWyCKhKnL3wgxnE5hVIkDj+8iY7SLmQ
        gLNE23UzkDCngIvE5kv7wCYyCohJfD+1BsxmFhCXuPVkPhPEbwISS/acZ4awRSVePv4H9gCj
        QCejxI1vp6GKFCXOb1gEdqeEQB+zxKnuh1AdNhIzuqdD2b4SnTdusEEUTWSUePbhBDtEIl/i
        3LepLBB2tcSetUuhir4xSZz48pcNIiEjcfzXbHaIRBOrxJ7DD9khQSElcfdKJ+MERq1ZSG6H
        sHUkFuz+xAZha0ssW/iaeRY4OAQlTs58wrKAkWUVo2hxanFSbrqRkV5qUWZycXF+nl5easkm
        RmCqObjlt8EOxpfPHQ8xCnAwKvHwKsz6HSHEmlhWXJl7iFGCg1lJhPfcgj8RQrwpiZVVqUX5
        8UWlOanFhxilOViUxHkd912IEBJITyxJzU5NLUgtgskycXBKNTD2p58J5HQJ/vtn8lOu8MUb
        ZN8tti7xuqeXFZRp//PyXv7ngrbGLtvyP719ZjPDQyFbIHfK5fJfG/bv/zA/4XQP6w3jK2F/
        pEJl3hy0v5J4d3lHFPOC+gPn9y/h06t7FeDodPaCuf4fz+OWfXEvf/LcVMssWJt0ePGSrMqT
        LuJH0mbw/nZ8l1alxFKckWioxVxUnAgAg+XWLDEDAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3NDXarH004379
Content-Length: 1312
Lines: 41

Acknowledged. Thank you for doing this job.

///jon


> -----Original Message-----
> From: Pan Bian [mailto:bianpan2016@163.com]
> Sent: Sunday, April 23, 2017 03:09 AM
> To: Jon Maloy <jon.maloy@ericsson.com>; Ying Xue
> <ying.xue@windriver.com>; David S. Miller <davem@davemloft.net>
> Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-
> kernel@vger.kernel.org; Pan Bian <bianpan2016@163.com>
> Subject: [PATCH 1/1] tipc: check return value of nlmsg_new
> 
> Function nlmsg_new() will return a NULL pointer if there is no enough
> memory, and its return value should be checked before it is used.
> However, in function tipc_nl_node_get_monitor(), the validation of the
> return value of function nlmsg_new() is missed. This patch fixes the bug.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  net/tipc/node.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/tipc/node.c b/net/tipc/node.c index 4512e83..568e48d 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -2098,6 +2098,8 @@ int tipc_nl_node_get_monitor(struct sk_buff *skb,
> struct genl_info *info)
>  	int err;
> 
>  	msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg.skb)
> +		return -ENOMEM;
>  	msg.portid = info->snd_portid;
>  	msg.seq = info->snd_seq;
> 
> --
> 1.9.1
>