Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1046363AbdDXFk5 (ORCPT ); Mon, 24 Apr 2017 01:40:57 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35932 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007AbdDXFkv (ORCPT ); Mon, 24 Apr 2017 01:40:51 -0400 Date: Mon, 24 Apr 2017 07:40:48 +0200 From: Jiri Pirko To: Pan Bian Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] team: fix memory leak Message-ID: <20170424054048.GA1886@nanopsycho.orion> References: <1492932564-722-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492932564-722-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 39 Sun, Apr 23, 2017 at 09:29:24AM CEST, bianpan2016@163.com wrote: >In function team_nl_send_port_list_get(), pointer skb keeps the return >value of nlmsg_new(). When the call to genlmsg_put() fails, the memory >is not freed. This will result in a memory leak bug. This patch fixes >it. > Looks good. Please adjust subject so the both patches have a specific one. Also, please add "Fixes" tag (see git log for details). Also, is is good to say which tree this patches are generated against ("-net") >Signed-off-by: Pan Bian >--- > drivers/net/team/team.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c >index f8c81f1..dd3a2e9 100644 >--- a/drivers/net/team/team.c >+++ b/drivers/net/team/team.c >@@ -2634,8 +2634,10 @@ static int team_nl_send_port_list_get(struct team *team, u32 portid, u32 seq, > > hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, > TEAM_CMD_PORT_LIST_GET); >- if (!hdr) >+ if (!hdr) { >+ nlmsg_free(skb); > return -EMSGSIZE; >+ } > > if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) > goto nla_put_failure; >-- >1.9.1 > >