Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164827AbdDXHF4 (ORCPT ); Mon, 24 Apr 2017 03:05:56 -0400 Received: from m12-18.163.com ([220.181.12.18]:53465 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165699AbdDXHFr (ORCPT ); Mon, 24 Apr 2017 03:05:47 -0400 From: Pan Bian To: Jiri Pirko , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/2] net: team: fix memory leak in team_nl_send_port_list_get Date: Mon, 24 Apr 2017 15:04:36 +0800 Message-Id: <1493017476-3535-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EsCowAAXtr6Ko_1YtowsAg--.54726S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr4DCF1kXF4ktrWkur1UAwb_yoWfKwbEga yI9rs7XwnYkrn7Kw1Fkr4xZryxtF4fZ3Z3WFyIk34ftr9IyrsrA3Z7Zr1DAa97Kr17Ca98 C34DJa43Z34xtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUn4UDJUUUUU== X-Originating-IP: [106.120.213.67] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBUQ3DclaDtxig-wAAsI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 31 In function team_nl_send_port_list_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed. This will result in a memory leak bug. This patch fixes it. Fixes: fbd69cda90e7 ("team: fix memory leak") Signed-off-by: Pan Bian --- drivers/net/team/team.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index f8c81f1..dd3a2e9 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2634,8 +2634,10 @@ static int team_nl_send_port_list_get(struct team *team, u32 portid, u32 seq, hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, TEAM_CMD_PORT_LIST_GET); - if (!hdr) + if (!hdr) { + nlmsg_free(skb); return -EMSGSIZE; + } if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) goto nla_put_failure; -- 1.9.1