Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1166219AbdDXHoX (ORCPT ); Mon, 24 Apr 2017 03:44:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37040 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165923AbdDXHoU (ORCPT ); Mon, 24 Apr 2017 03:44:20 -0400 Date: Mon, 24 Apr 2017 09:44:17 +0200 From: Pavel Machek To: David Lin Cc: rpurdie@rpsys.net, jacek.anaszewski@gmail.com, robh@kernel.org, romlem@google.com, joelaf@google.com, stable@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer Message-ID: <20170424074417.GA24242@amd> References: <20170424044254.145192-1-dtwlin@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20170424044254.145192-1-dtwlin@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 42 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2017-04-23 21:42:54, David Lin wrote: > This patch replaces the kernel timer used by led transient trigger as an > one-shot timer with an hrtimer. As Android is moving away from the > obsoleted timed_output to ledtrig-transient for the vibrator HAL, > ledtrig-transient needs to be able to handle the "duration" property to > millisecond precision as modern haptic actuators can be driven in > precisely one cycle (~1 ms) in order to provide a crisp and subtle > feedback. (Insert rant about using LED subsystem for something that is not a LED; if we are going to these subtleties, LEDs _do_ have different properties than vibration motor...). Otherwise it looks good. Acked-by: Pavel Machek Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlj9rNEACgkQMOfwapXb+vI4KQCfSw32t8VAXFqTkt01pHjX7Wq+ 8qkAn3ghvZWhwaD2psL1kHdl/Gl65UPN =Zk/U -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--