Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167248AbdDXIyP (ORCPT ); Mon, 24 Apr 2017 04:54:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:22177 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1167221AbdDXIx7 (ORCPT ); Mon, 24 Apr 2017 04:53:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,243,1488873600"; d="scan'208";a="960371019" Message-ID: <1493023852.24567.148.camel@linux.intel.com> Subject: Re: [PATCH v1 2/8] ASoC: Intel: Skylake: Use recently introduced uuid_le_cmp_p{p}() From: Andy Shevchenko To: Vinod Koul Cc: Andrew Morton , linux-kernel@vger.kernel.org, Arnd Bergmann , Mika Westerberg , alsa-devel@alsa-project.org, linux-input@vger.kernel.org, kvm@vger.kernel.org, devel@linuxdriverproject.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org, Liam Girdwood , Mark Brown Date: Mon, 24 Apr 2017 11:50:52 +0300 In-Reply-To: <20170424045105.GF6263@localhost> References: <20170421144645.45189-1-andriy.shevchenko@linux.intel.com> <20170421144645.45189-2-andriy.shevchenko@linux.intel.com> <20170424045105.GF6263@localhost> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2864 Lines: 86 On Mon, 2017-04-24 at 10:21 +0530, Vinod Koul wrote: > On Fri, Apr 21, 2017 at 05:46:39PM +0300, Andy Shevchenko wrote: > > Recently introduced helpers take pointers to uuid_{be|le} instead of > > reference. > > Are they in linus's tree, if not it introduces dependency, so we might > want > to defer after merge window You are Cc'ed to patch 1 which brings them. > > > > Using them makes code less ugly. > > How so..? Consider below example. - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { + if (uuid_le_cmp_p(uuid_mod, module->uuid) == 0) { There are two points: 1) caller don't need to dereference pointers to its values; 2) this allow compiler to not copy the data (though clever compiler might optimize that). > > > > > Cc: Liam Girdwood > > Cc: Mark Brown > > Cc: Vinod Koul > > Signed-off-by: Andy Shevchenko > > --- > >  sound/soc/intel/skylake/skl-pcm.c       | 2 +- > >  sound/soc/intel/skylake/skl-sst-utils.c | 4 ++-- > >  2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/sound/soc/intel/skylake/skl-pcm.c > > b/sound/soc/intel/skylake/skl-pcm.c > > index 600faad19bd4..4bf171985872 100644 > > --- a/sound/soc/intel/skylake/skl-pcm.c > > +++ b/sound/soc/intel/skylake/skl-pcm.c > > @@ -1207,7 +1207,7 @@ static int skl_get_module_info(struct skl > > *skl, struct skl_module_cfg *mconfig) > >   } > >   > >   list_for_each_entry(module, &ctx->uuid_list, list) { > > - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { > > + if (uuid_le_cmp_p(uuid_mod, module->uuid) == 0) { > >   mconfig->id.module_id = module->id; > >   mconfig->is_loadable = module->is_loadable; > >   return 0; > > diff --git a/sound/soc/intel/skylake/skl-sst-utils.c > > b/sound/soc/intel/skylake/skl-sst-utils.c > > index 6d5bff04bf65..67288580c743 100644 > > --- a/sound/soc/intel/skylake/skl-sst-utils.c > > +++ b/sound/soc/intel/skylake/skl-sst-utils.c > > @@ -189,7 +189,7 @@ int skl_get_pvt_id(struct skl_sst *ctx, uuid_le > > *uuid_mod, int instance_id) > >   int pvt_id; > >   > >   list_for_each_entry(module, &ctx->uuid_list, list) { > > - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { > > + if (uuid_le_cmp_p(uuid_mod, module->uuid) == 0) { > >   > >   pvt_id = skl_pvtid_128(module); > >   if (pvt_id >= 0) { > > @@ -218,7 +218,7 @@ int skl_put_pvt_id(struct skl_sst *ctx, uuid_le > > *uuid_mod, int *pvt_id) > >   struct uuid_module *module; > >   > >   list_for_each_entry(module, &ctx->uuid_list, list) { > > - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { > > + if (uuid_le_cmp_p(uuid_mod, module->uuid) == 0) { > >   > >   if (*pvt_id != 0) > >   i = (*pvt_id) / 64; > > --  > > 2.11.0 > > > > -- Andy Shevchenko Intel Finland Oy