DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D483880F94
Date: Mon, 24 Apr 2017 17:00:40 +0800
From: Baoquan He <bhe@redhat.com>
To: kbuild test robot <lkp@intel.com>, fengguang.wu@intel.com
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, keescook@chromium.org,
        mingo@kernel.org, dave.jiang@intel.com, dan.j.williams@intel.com,
        hpa@zytor.com, tglx@linutronix.de, dyoung@redhat.com,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [RFC PATCH] KASLR: mem_avoid_memmap_index can be static
Message-ID: <20170424090040.GC2310@x1>
References: <201704241606.VlTnAXb4%fengguang.wu@intel.com>
 <20170424084818.GA10777@lkp-wsm-ep2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170424084818.GA10777@lkp-wsm-ep2>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 898
Lines: 32

Hi Fengguang,

Thanks for pointing it out!

I am fine with defining mem_avoid_memmap_index it as static variable.
While Liyang suggested using a local static inside mem_avoid_memmap,
then mem_avoid_memmap_index is not needed any more. Do you think it's OK
to you?

Thanks
Baoquan

On 04/24/17 at 04:48pm, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  kaslr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
> index 6649ecd..7190d35 100644
> --- a/arch/x86/boot/compressed/kaslr.c
> +++ b/arch/x86/boot/compressed/kaslr.c
> @@ -75,7 +75,7 @@ struct mem_vector {
>  #define MAX_MEMMAP_REGIONS	4
>  
>  static bool memmap_too_large;
> -int mem_avoid_memmap_index;
> +static int mem_avoid_memmap_index;
>  extern unsigned long get_cmd_line_ptr(void);
>  
>