DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CEEF223E6D0
Date: Mon, 24 Apr 2017 17:08:24 +0800
From: Baoquan He <bhe@redhat.com>
To: Fengguang Wu <lkp@intel.com>
Cc: dave.jiang@intel.com, keescook@chromium.org,
        Yinghai Lu <yinghai@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        tglx@linutronix.de, kbuild-all@01.org, hpa@zytor.com,
        dan.j.williams@intel.com, Borislav Petkov <bp@suse.de>,
        dyoung@redhat.com, mingo@kernel.org
Subject: Re: [kbuild-all] [RFC PATCH] KASLR: mem_avoid_memmap_index can be
 static
Message-ID: <20170424090824.GA6089@x1>
References: <201704241606.VlTnAXb4%fengguang.wu@intel.com>
 <20170424084818.GA10777@lkp-wsm-ep2>
 <20170424090040.GC2310@x1>
 <20170424090428.sa7boyuhkyklqxv5@wfg-t540p.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170424090428.sa7boyuhkyklqxv5@wfg-t540p.sh.intel.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1464
Lines: 43

On 04/24/17 at 05:04pm, Fengguang Wu wrote:
> Hi Baoquan,
> 
> On Mon, Apr 24, 2017 at 05:00:40PM +0800, Baoquan He wrote:
> > Hi Fengguang,
> > 
> > Thanks for pointing it out!
> > 
> > I am fine with defining mem_avoid_memmap_index it as static variable.
> > While Liyang suggested using a local static inside mem_avoid_memmap,
> > then mem_avoid_memmap_index is not needed any more. Do you think it's OK
> > to you?
> 
> Yes, that'd be a better solution. It's a robot generated patch and is
> open for optimization or correction.

Oh, the tip robot is so great! Thanks for telling, then let me repost.

> 
> > On 04/24/17 at 04:48pm, kbuild test robot wrote:
> > > 
> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > > ---
> > >  kaslr.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
> > > index 6649ecd..7190d35 100644
> > > --- a/arch/x86/boot/compressed/kaslr.c
> > > +++ b/arch/x86/boot/compressed/kaslr.c
> > > @@ -75,7 +75,7 @@ struct mem_vector {
> > >  #define MAX_MEMMAP_REGIONS	4
> > > 
> > >  static bool memmap_too_large;
> > > -int mem_avoid_memmap_index;
> > > +static int mem_avoid_memmap_index;
> > >  extern unsigned long get_cmd_line_ptr(void);
> > > 
> > > 
> > _______________________________________________
> > kbuild-all mailing list
> > kbuild-all@lists.01.org
> > https://lists.01.org/mailman/listinfo/kbuild-all