Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167892AbdDXJSj (ORCPT ); Mon, 24 Apr 2017 05:18:39 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:33156 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1167812AbdDXJSc (ORCPT ); Mon, 24 Apr 2017 05:18:32 -0400 MIME-Version: 1.0 In-Reply-To: <20170414154056.32055-2-ralph.sennhauser@gmail.com> References: <20170414154056.32055-1-ralph.sennhauser@gmail.com> <20170414154056.32055-2-ralph.sennhauser@gmail.com> From: Linus Walleij Date: Mon, 24 Apr 2017 11:18:30 +0200 Message-ID: Subject: Re: [PATCH v6 1/4] gpio: mvebu: Add limited PWM support To: Ralph Sennhauser Cc: "linux-gpio@vger.kernel.org" , Andrew Lunn , Thierry Reding , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Russell King , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 36 On Fri, Apr 14, 2017 at 5:40 PM, Ralph Sennhauser wrote: > From: Andrew Lunn > > Armada 370/XP devices can 'blink' GPIO lines with a configurable on > and off period. This can be modelled as a PWM. > > However, there are only two sets of PWM configuration registers for > all the GPIO lines. This driver simply allows a single GPIO line per > GPIO chip of 32 lines to be used as a PWM. Attempts to use more return > EBUSY. > > Due to the interleaving of registers it is not simple to separate the > PWM driver from the GPIO driver. Thus the GPIO driver has been > extended with a PWM driver. > > Signed-off-by: Andrew Lunn > URL: https://patchwork.ozlabs.org/patch/427287/ > URL: https://patchwork.ozlabs.org/patch/427295/ > [Ralph Sennhauser: > * Port forward > * Merge PWM portion into gpio-mvebu.c > * Switch to atomic PWM API > * Add new compatible string marvell,armada-370-xp-gpio > * Update and merge documentation patch > * Update MAINTAINERS] > Signed-off-by: Ralph Sennhauser > Tested-by: Andrew Lunn > Acked-by: Thierry Reding > Acked-by: Rob Herring Patch applied. Yours, Linus Walleij