Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168530AbdDXKaO (ORCPT ); Mon, 24 Apr 2017 06:30:14 -0400 Received: from m12-13.163.com ([220.181.12.13]:35095 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758410AbdDXKaH (ORCPT ); Mon, 24 Apr 2017 06:30:07 -0400 From: Pan Bian To: Jiri Pirko , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH net] team: fix memory leaks Date: Mon, 24 Apr 2017 18:29:16 +0800 Message-Id: <1493029756-13171-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DcCowAAX8VOL0_1YwCAHAA--.1502S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7CF13trWUtry8Cr4UZFWrKrg_yoW8GFy3p3 yrCa40kryDt3WjvanxC3WkWr45Cw1xZF9FkrW5Ca98Cr4Yv3WUtw1qkFyUtFnayw48AF4f Zr1DtwnxWFnFkwUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j2SoXUUUUU= X-Originating-IP: [106.120.213.67] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBZwbDcletlmscjgABsE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 42 In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This will result in memory leak bugs. Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers") Signed-off-by: Pan Bian --- drivers/net/team/team.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index f8c81f1..85c0124 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2361,8 +2361,10 @@ static int team_nl_send_options_get(struct team *team, u32 portid, u32 seq, hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, TEAM_CMD_OPTIONS_GET); - if (!hdr) + if (!hdr) { + nlmsg_free(skb); return -EMSGSIZE; + } if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) goto nla_put_failure; @@ -2634,8 +2636,10 @@ static int team_nl_send_port_list_get(struct team *team, u32 portid, u32 seq, hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, TEAM_CMD_PORT_LIST_GET); - if (!hdr) + if (!hdr) { + nlmsg_free(skb); return -EMSGSIZE; + } if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) goto nla_put_failure; -- 1.9.1