Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1169036AbdDXK6K (ORCPT ); Mon, 24 Apr 2017 06:58:10 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37706 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1169021AbdDXK6B (ORCPT ); Mon, 24 Apr 2017 06:58:01 -0400 Date: Mon, 24 Apr 2017 11:57:56 +0100 From: Lee Jones To: Olimpiu Dejeu Cc: Daniel Thompson , kbuild test robot , fengguang.wu@intel.com, kbuild-all@01.org, Rob Herring , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, Brian Dodge , joe@perches.com, "Matthew D'Asaro" Subject: Re: [PATCH] fix ptr_ret.cocci warnings Message-ID: <20170424105756.im6hjljqvyktzh6n@dell> References: <201703172233.osJjGFrP%fengguang.wu@intel.com> <1489607133-7870-3-git-send-email-olimpiu@arcticsand.com> <20170317144809.GA103304@lkp-hsx03.lkp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 68 On Mon, 17 Apr 2017, Olimpiu Dejeu wrote: > On Tue, Mar 21, 2017 at 11:07 AM, Daniel Thompson < > daniel.thompson@linaro.org> wrote: > > > On 21/03/17 14:58, Olimpiu Dejeu wrote: > > > >> On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot > >> wrote: > >> > >>> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO > >>> can be used > >>> > >>> > >>> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > >>> > >>> Generated by: scripts/coccinelle/api/ptr_ret.cocci > >>> > >>> CC: Olimpiu Dejeu > >>> Signed-off-by: Fengguang Wu > >>> --- > >>> > >>> arcxcnn_bl.c | 5 +---- > >>> 1 file changed, 1 insertion(+), 4 deletions(-) > >>> > >>> --- a/drivers/video/backlight/arcxcnn_bl.c > >>> +++ b/drivers/video/backlight/arcxcnn_bl.c > >>> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st > >>> > >>> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, > >>> lp, > >>> &arcxcnn_bl_ops, props); > >>> - if (IS_ERR(lp->bl)) > >>> - return PTR_ERR(lp->bl); > >>> - > >>> - return 0; > >>> + return PTR_ERR_OR_ZERO(lp->bl); > >>> } > >>> > >>> static void arcxcnn_parse_dt(struct arcxcnn *lp) > >>> > >> > >> Acked-by: Olimpiu Dejeu > >> > > > > Glad you approve! Could you apply this change and re-post the patch > > series? Thanks. > > > > > > Daniel. > > > > > Applied change, re-posted series on March 21st. No sure what next. Please > advise. Thanks. Yes you did. Daniel, do you see v9? FYI, if this happens again, it's best to wait a couple of weeks then send the patch again like "[RESEND v9] ..." to gain attention. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog