Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1169210AbdDXL1C (ORCPT ); Mon, 24 Apr 2017 07:27:02 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:33981 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1169179AbdDXL0v (ORCPT ); Mon, 24 Apr 2017 07:26:51 -0400 Subject: Re: [PATCH] fix ptr_ret.cocci warnings To: Lee Jones , Olimpiu Dejeu References: <201703172233.osJjGFrP%fengguang.wu@intel.com> <1489607133-7870-3-git-send-email-olimpiu@arcticsand.com> <20170317144809.GA103304@lkp-hsx03.lkp.intel.com> <20170424105756.im6hjljqvyktzh6n@dell> Cc: kbuild test robot , fengguang.wu@intel.com, kbuild-all@01.org, Rob Herring , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, Brian Dodge , joe@perches.com, "Matthew D'Asaro" From: Daniel Thompson Message-ID: <5f719f78-2890-f9e0-dfc7-f7217432dad0@linaro.org> Date: Mon, 24 Apr 2017 12:26:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170424105756.im6hjljqvyktzh6n@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2228 Lines: 76 On 24/04/17 11:57, Lee Jones wrote: > On Mon, 17 Apr 2017, Olimpiu Dejeu wrote: > >> On Tue, Mar 21, 2017 at 11:07 AM, Daniel Thompson < >> daniel.thompson@linaro.org> wrote: >> >>> On 21/03/17 14:58, Olimpiu Dejeu wrote: >>> >>>> On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot >>>> wrote: >>>> >>>>> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO >>>>> can be used >>>>> >>>>> >>>>> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >>>>> >>>>> Generated by: scripts/coccinelle/api/ptr_ret.cocci >>>>> >>>>> CC: Olimpiu Dejeu >>>>> Signed-off-by: Fengguang Wu >>>>> --- >>>>> >>>>> arcxcnn_bl.c | 5 +---- >>>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>>> >>>>> --- a/drivers/video/backlight/arcxcnn_bl.c >>>>> +++ b/drivers/video/backlight/arcxcnn_bl.c >>>>> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st >>>>> >>>>> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, >>>>> lp, >>>>> &arcxcnn_bl_ops, props); >>>>> - if (IS_ERR(lp->bl)) >>>>> - return PTR_ERR(lp->bl); >>>>> - >>>>> - return 0; >>>>> + return PTR_ERR_OR_ZERO(lp->bl); >>>>> } >>>>> >>>>> static void arcxcnn_parse_dt(struct arcxcnn *lp) >>>>> >>>> >>>> Acked-by: Olimpiu Dejeu >>>> >>> >>> Glad you approve! Could you apply this change and re-post the patch >>> series? Thanks. >>> >>> >>> Daniel. >>> >>> >> Applied change, re-posted series on March 21st. No sure what next. Please >> advise. Thanks. > > Yes you did. > > Daniel, do you see v9? Yep. All fine at my end... it has my Reviewed-by: which is an even more emphatic statement than my Acked-by: ;-) . I think from this point on I think I'll start posting "[vX-is-still-]Acked-by:" replies so you don't have to worry about whether I've seen new versions. > FYI, if this happens again, it's best to wait a couple of weeks then > send the patch again like "[RESEND v9] ..." to gain attention. RESENDs are a good way to go. Also, if there are questions about the code its better to reply to the code rather than the side discussion. Daniel.