DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ADB043DBC1
Date: Mon, 24 Apr 2017 13:37:20 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Taeung Song <treeze.taeung@gmail.com>,
        Jin Yao <yao.jin@linux.intel.com>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command
 name
Message-ID: <20170424113720.GA4455@krava>
References: <20170420092430.29657-1-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170420092430.29657-1-jolsa@kernel.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1583
Lines: 52


Arnaldo,
could you please take this one?

thanks,
jirka

On Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa wrote:
> Recent commit broke command name strip in perf_event__get_comm_ids
> function. It replaced left to right search for '\n' with rtrim,
> which actually does right to left search. It occasionally caught
> earlier '\n' and kept trash in the command name.
> 
> Keeping the ltrim, but moving back the left to right '\n' search
> instead of the rtrim.
> 
> Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name with {l,r}trim()")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Cc: Jin Yao <yao.jin@linux.intel.com>
> Link: http://lkml.kernel.org/n/tip-51mt8hxaig74zlu42s3rv0i7@git.kernel.org
> ---
>  tools/perf/util/event.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index cf457ef534da..1a9164a816d9 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -138,8 +138,15 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
>  	ppids = strstr(bf, "PPid:");
>  
>  	if (name) {
> +		char *nl;
> +
>  		name += 5;  /* strlen("Name:") */
> -		name = rtrim(ltrim(name));
> +		name = ltrim(name);
> +
> +		nl = strchr(name, '\n');
> +		if (nl)
> +			*nl = '\0';
> +
>  		size = strlen(name);
>  		if (size >= len)
>  			size = len - 1;
> -- 
> 2.9.3
>