Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1170445AbdDXM7T (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Apr 2017 08:59:19 -0400
Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:33898 "EHLO
        smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1170319AbdDXM7M (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Apr 2017 08:59:12 -0400
MIME-Version: 1.0
In-Reply-To: <20170424122411.GA9349@Red>
References: <20170412111400.2296-1-clabbe.montjoie@gmail.com>
 <20170412111400.2296-14-clabbe.montjoie@gmail.com> <20170412124153.q6zvdvqkroizaxgb@lukather>
 <20170424122411.GA9349@Red>
From: Chen-Yu Tsai <wens@csie.org>
Date: Mon, 24 Apr 2017 20:58:44 +0800
X-Gmail-Original-Message-ID: <CAGb2v66_=dPovgjh-t3ocsAkh7zMNJfa8aRJOUP59K=-zrVb-g@mail.gmail.com>
Message-ID: <CAGb2v66_=dPovgjh-t3ocsAkh7zMNJfa8aRJOUP59K=-zrVb-g@mail.gmail.com>
Subject: Re: [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i
 Ethernet driver
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Chen-Yu Tsai <wens@csie.org>, Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>, alexandre.torgue@st.com,
        linux-sunxi <linux-sunxi@googlegroups.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1963
Lines: 49

On Mon, Apr 24, 2017 at 8:24 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote:
>> On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote:
>> > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit
>> > connections. It is very similar to the device found in the Allwinner
>> > H3, but lacks the internal 100 Mbit PHY and its associated control
>> > bits.
>> > This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps
>> > it disabled at this level.
>> >
>> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>> > ---
>> >  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++
>> >  1 file changed, 37 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> > index 0b0f4ab..2569827 100644
>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> > @@ -287,6 +287,23 @@
>> >                             bias-pull-up;
>> >                     };
>> >
>> > +                   rmii_pins: rmii_pins {
>> > +                           pins = "PD10", "PD11", "PD13", "PD14",
>> > +                                           "PD17", "PD18", "PD19", "PD20",
>> > +                                           "PD22", "PD23";
>>
>> Please align the wrapped lines on the first pin.
>>
>
> OK
>
>> > +                           function = "emac";
>> > +                           drive-strength = <40>;
>>
>> Do you actually need that for all the boards, or only a few of them?
>
> I have tried to use lower value without success on some boards. (opipc/pine64 in my memory)

FYI we need them for all the boards that use RGMII.
The signals at gigabit speed run at 125 MHz DDR.

For RMII we probably don't need it. Even at 100 Mbps,
it's only 50 MHz SDR. drive-strength = <30> should be
enough.

ChenYu