Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762859AbdDXOSv (ORCPT ); Mon, 24 Apr 2017 10:18:51 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36075 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1171491AbdDXOSn (ORCPT ); Mon, 24 Apr 2017 10:18:43 -0400 From: Corentin Labbe To: herbert@gondor.apana.org.au, davem@davemloft.net, thomas.lendacky@amd.com, gary.hook@amd.com, boris.brezillon@free-electrons.com, arno@natisbad.org, matthias.bgg@gmail.com, giovanni.cabiddu@intel.com, salvatore.benedetto@intel.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, qat-linux@intel.com, Corentin Labbe Subject: [PATCH 1/9] crypto: add hmac IPAD/OPAD constant Date: Mon, 24 Apr 2017 16:16:21 +0200 Message-Id: <20170424141629.27155-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 41 Many HMAC users directly use directly 0x36/0x5c values. It's better with crypto to use a name instead of directly some crypto constant. This patch simply add HMAC_IPAD_VALUE/HMAC_OPAD_VALUE defines. Signed-off-by: Corentin Labbe --- crypto/hmac.c | 4 ++-- include/crypto/hash.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crypto/hmac.c b/crypto/hmac.c index 72e38c0..4a997ce 100644 --- a/crypto/hmac.c +++ b/crypto/hmac.c @@ -74,8 +74,8 @@ static int hmac_setkey(struct crypto_shash *parent, memcpy(opad, ipad, bs); for (i = 0; i < bs; i++) { - ipad[i] ^= 0x36; - opad[i] ^= 0x5c; + ipad[i] ^= HMAC_IPAD_VALUE; + opad[i] ^= HMAC_OPAD_VALUE; } return crypto_shash_init(shash) ?: diff --git a/include/crypto/hash.h b/include/crypto/hash.h index b5727bc..0f51ff1 100644 --- a/include/crypto/hash.h +++ b/include/crypto/hash.h @@ -922,4 +922,7 @@ static inline void shash_desc_zero(struct shash_desc *desc) sizeof(*desc) + crypto_shash_descsize(desc->tfm)); } +#define HMAC_IPAD_VALUE 0x36 +#define HMAC_OPAD_VALUE 0x5c + #endif /* _CRYPTO_HASH_H */ -- 2.10.2