Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1172649AbdDXO3S (ORCPT ); Mon, 24 Apr 2017 10:29:18 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:36444 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1172550AbdDXO3H (ORCPT ); Mon, 24 Apr 2017 10:29:07 -0400 MIME-Version: 1.0 In-Reply-To: <20170419195905.9937-1-paul.gortmaker@windriver.com> References: <20170419195905.9937-1-paul.gortmaker@windriver.com> From: Linus Walleij Date: Mon, 24 Apr 2017 16:29:05 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: make artpec6 explicitly non-modular To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Jesper Nilsson , Lars Persson , Niklas Cassel , linux-arm-kernel@axis.com, "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 30 On Wed, Apr 19, 2017 at 9:59 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pinctrl/Kconfig:config PINCTRL_ARTPEC6 > drivers/pinctrl/Kconfig: bool "Axis ARTPEC-6 pin controller driver" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Jesper Nilsson > Cc: Lars Persson > Cc: Niklas Cassel > Cc: Linus Walleij > Cc: linux-arm-kernel@axis.com > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied with Jesper's ACK. Yours, Linus Walleij