Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1173132AbdDXPKY (ORCPT ); Mon, 24 Apr 2017 11:10:24 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:40467 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1172305AbdDXPKP (ORCPT ); Mon, 24 Apr 2017 11:10:15 -0400 Date: Mon, 24 Apr 2017 08:10:13 -0700 From: Christoph Hellwig To: NeilBrown Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. Message-ID: <20170424151013.GA17867@infradead.org> References: <149266645258.27388.14083229348123176454.stgit@noble> <149266672858.27388.11409778158413625707.stgit@noble> <20170421112458.GB12523@infradead.org> <87h91er2t6.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h91er2t6.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 17 On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: > > I was following the existing practice exemplified by > bioset_create_nobvec(). Which is pretty ugly to start with.. > By not changing the signature of the function, I can avoid touching > quite a few places where it is called. There are 13 callers of bioset_create and one caller of bioset_create_nobvec, and your series touches many of those. So just adding a flags argument to bioset_create and passing BIOSET_NEED_BVECS and BIOSET_NEED_RESUER flags to it doesn't seem to much of an effort, and it's going to create a much nicer and easier to extend interface.