Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1172301AbdDXPra convert rfc822-to-8bit (ORCPT ); Mon, 24 Apr 2017 11:47:30 -0400 Received: from smtp-out4.electric.net ([192.162.216.195]:60576 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165000AbdDXPpy (ORCPT ); Mon, 24 Apr 2017 11:45:54 -0400 From: David Laight To: "'Shuah Khan'" , "shuah@kernel.org" , "bamvor.zhangjian@linaro.org" , "benh@kernel.crashing.org" , "paulus@samba.org" , "mpe@ellerman.id.au" , "dvhart@infradead.org" CC: "linux-kselftest@vger.kernel.org" , "rkrcmar@redhat.com" , "dsafonov@virtuozzo.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "emilio.lopez@collabora.co.uk" , "linux-gpio@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "luto@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "mingo@kernel.org" Subject: RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Thread-Topic: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Thread-Index: AQHSuvab44I2Fu4Mh0SIRtkxy4d02KHUqJOw Date: Mon, 24 Apr 2017 15:45:26 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFD98E2@AcuExch.aculab.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 37 From: Shuah Khan > Sent: 22 April 2017 00:15 > Define CLEAN macro to allow Makefiles to override common clean target > in lib.mk. This will help fix the following failures: > > warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/lib.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 775c589..959273c 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -51,8 +51,12 @@ endef > emit_tests: > $(EMIT_TESTS) > > -clean: > +define CLEAN > $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) > +endef > + > +clean: > + $(CLEAN) If might be easier to do something like: ifneq($(NO_CLEAN),y) clean: $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) endif David