Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S972459AbdDXP40 (ORCPT ); Mon, 24 Apr 2017 11:56:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:48352 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S972419AbdDXP4T (ORCPT ); Mon, 24 Apr 2017 11:56:19 -0400 Date: Mon, 24 Apr 2017 17:56:14 +0200 From: Jan Kara To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net, linux-xfs@vger.kernel.org, cluster-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org, linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org, dhowells@redhat.com, akpm@linux-foundation.org, hch@infradead.org, ross.zwisler@linux.intel.com, mawilcox@microsoft.com, jack@suse.com, viro@zeniv.linux.org.uk, corbet@lwn.net, neilb@suse.de, clm@fb.com, tytso@mit.edu, axboe@kernel.dk Subject: Re: [PATCH v3 08/20] mm: ensure that we set mapping error if writeout() fails Message-ID: <20170424155614.GI23988@quack2.suse.cz> References: <20170424132259.8680-1-jlayton@redhat.com> <20170424132259.8680-9-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424132259.8680-9-jlayton@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 39 On Mon 24-04-17 09:22:47, Jeff Layton wrote: > If writepage fails during a page migration, then we need to ensure that > fsync will see it by flagging the mapping. > > Signed-off-by: Jeff Layton Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > mm/migrate.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 738f1d5f8350..3a59830bdae2 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -792,7 +792,11 @@ static int writeout(struct address_space *mapping, struct page *page) > /* unlocked. Relock */ > lock_page(page); > > - return (rc < 0) ? -EIO : -EAGAIN; > + if (rc < 0) { > + mapping_set_error(mapping, rc); > + return -EIO; > + } > + return -EAGAIN; > } > > /* > -- > 2.9.3 > > -- Jan Kara SUSE Labs, CR