Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1173524AbdDXQ2t (ORCPT ); Mon, 24 Apr 2017 12:28:49 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:34045 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S973577AbdDXQ2Q (ORCPT ); Mon, 24 Apr 2017 12:28:16 -0400 MIME-Version: 1.0 In-Reply-To: <21442d70-e77b-8338-30f7-9c41d048a665@users.sourceforge.net> References: <1492720999.3041.18.camel@redhat.com> <86425035-7da8-d2b1-8544-d4f7540d50c6@users.sourceforge.net> <21442d70-e77b-8338-30f7-9c41d048a665@users.sourceforge.net> From: Devesh Sharma Date: Mon, 24 Apr 2017 21:57:34 +0530 Message-ID: Subject: Re: [PATCH v2 01/12] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range() To: SF Markus Elfring Cc: Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , Yuval Shaia , linux-rdma , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3280 Lines: 69 Acked-By: Devesh Sharma On Sat, Apr 22, 2017 at 8:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 11:33:25 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus reuse the corresponding function "kcalloc". > > This issue was detected by using the Coccinelle software. > > * Delete the local variable "pd_bitmap_size" which became unnecessary > with this refactoring. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index aa6967197620..c868314222b9 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1505,7 +1505,6 @@ int ocrdma_mbx_dealloc_pd(struct ocrdma_dev *dev, struct ocrdma_pd *pd) > static int ocrdma_mbx_alloc_pd_range(struct ocrdma_dev *dev) > { > int status = -ENOMEM; > - size_t pd_bitmap_size; > struct ocrdma_alloc_pd_range *cmd; > struct ocrdma_alloc_pd_range_rsp *rsp; > > @@ -1527,10 +1526,10 @@ static int ocrdma_mbx_alloc_pd_range(struct ocrdma_dev *dev) > dev->pd_mgr->pd_dpp_start = rsp->dpp_page_pdid & > OCRDMA_ALLOC_PD_RNG_RSP_START_PDID_MASK; > dev->pd_mgr->max_dpp_pd = rsp->pd_count; > - pd_bitmap_size = > - BITS_TO_LONGS(rsp->pd_count) * sizeof(long); > - dev->pd_mgr->pd_dpp_bitmap = kzalloc(pd_bitmap_size, > - GFP_KERNEL); > + dev->pd_mgr->pd_dpp_bitmap > + = kcalloc(BITS_TO_LONGS(rsp->pd_count), > + sizeof(long), > + GFP_KERNEL); > } > kfree(cmd); > } > @@ -1546,9 +1545,10 @@ static int ocrdma_mbx_alloc_pd_range(struct ocrdma_dev *dev) > dev->pd_mgr->pd_norm_start = rsp->dpp_page_pdid & > OCRDMA_ALLOC_PD_RNG_RSP_START_PDID_MASK; > dev->pd_mgr->max_normal_pd = rsp->pd_count; > - pd_bitmap_size = BITS_TO_LONGS(rsp->pd_count) * sizeof(long); > - dev->pd_mgr->pd_norm_bitmap = kzalloc(pd_bitmap_size, > - GFP_KERNEL); > + dev->pd_mgr->pd_norm_bitmap > + = kcalloc(BITS_TO_LONGS(rsp->pd_count), > + sizeof(long), > + GFP_KERNEL); > } > kfree(cmd); > > -- > 2.12.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html