Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1173542AbdDXQ27 (ORCPT ); Mon, 24 Apr 2017 12:28:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:47536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1173514AbdDXQ2q (ORCPT ); Mon, 24 Apr 2017 12:28:46 -0400 Date: Mon, 24 Apr 2017 13:28:39 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , David Ahern , Namhyung Kim , Peter Zijlstra , Taeung Song , Jin Yao , lkml , Ingo Molnar Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name Message-ID: <20170424162839.GC2742@kernel.org> References: <20170420092430.29657-1-jolsa@kernel.org> <20170424154450.GB2742@kernel.org> <20170424160645.GA4120@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424160645.GA4120@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 34 Em Mon, Apr 24, 2017 at 06:06:45PM +0200, Jiri Olsa escreveu: > On Mon, Apr 24, 2017 at 12:44:50PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa escreveu: > > > Recent commit broke command name strip in perf_event__get_comm_ids > > > function. It replaced left to right search for '\n' with rtrim, > > > which actually does right to left search. It occasionally caught > > > earlier '\n' and kept trash in the command name. > > > > > > Keeping the ltrim, but moving back the left to right '\n' search > > > instead of the rtrim. > > > > perf/urgent? > > > > > Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name with {l,r}trim()") > > > > [acme@jouet linux]$ git tag --contains bdd97ca63faa > > perf-core-for-mingo-4.12-20170411 > > perf-core-for-mingo-4.12-20170413 > > perf-core-for-mingo-4.12-20170419 > > [acme@jouet linux]$ > > > > It is just in tip/perf/core, will put in acme/perf/core and push to Ingo > > in my next pull req. > > sure, I did not check.. just thought it's urgent from time POV ;-) :-) I took it too literally then, tried to apply it to perf/urgent, it failed, scratched my head... Anyway, applied. - Arnaldo