Date: Mon, 24 Apr 2017 10:02:05 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Shuah Khan <shuah@kernel.org>
Cc: priyalee.kushwaha@intel.com, josh@joshtriplett.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Kushwaha@ezm04-pco.easydns.vpn, ldr709@gmail.com
Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk
Reply-To: paulmck@linux.vnet.ibm.com
References: <1ad554b0025913fedf4ec3c7953d1a42fe1f0dde.1492879165.git.priyalee.kushwaha@intel.com>
 <dfbc644a-ffbf-b5b3-ebe2-05fbe7d9d9dd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dfbc644a-ffbf-b5b3-ebe2-05fbe7d9d9dd@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-Id: <20170424170205.GL3956@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1800
Lines: 44

On Mon, Apr 24, 2017 at 08:02:10AM -0600, Shuah Khan wrote:
> On 04/22/2017 11:17 AM, priyalee.kushwaha@intel.com wrote:
> > From: Priyalee Kushwaha <priyalee.kushwaha@intel.com>
> > 
> > Most OS distribution have awk in /usr/bin not in /bin
> > Without this patch, kernel-devsrc fails to build as
> > runtime dependency for srcu-cbmc script /bin/awk is
> > not found.
> > 
> > Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@intel.com>
> > ---
> >  tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > index 8ff8904..c9e8bc5 100755
> > --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > @@ -1,4 +1,4 @@
> > -#!/bin/awk -f
> > +#!/usr/bin/awk -f
> >  
> >  # Modify SRCU for formal verification. The first argument should be srcu.h and
> >  # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the
> > 
> 
> Hi Paul,
> 
> If this change looks good, please Ack it so I can take it through kselftest
> tree. If you would like to take this through rcu, that is fine as well.

Hello, Shuah,

I have queued it with Lance's ack and Josh's review.

Just for full disclosure, my recent SRCU work has broken srcu-cbmc,
and a bit more breakage is on its way.  :-(

That said, I would welcome patches to fix it -- mostly adjustments in
pathnames, structure names, and which fields get removed.  Adjusting it
to work correctly with Classic SRCU would probably be a bit easier than
adapting it to either Tree SRCU or Tiny SRCU.

							Thanx, Paul