Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S976831AbdDXSXA (ORCPT ); Mon, 24 Apr 2017 14:23:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33749 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S971764AbdDXSWy (ORCPT ); Mon, 24 Apr 2017 14:22:54 -0400 Subject: Re: [PATCH 1/3 v2] xen: Export xen_reboot To: Julien Grall , xen-devel@lists.xen.org References: <20170424175839.5262-1-julien.grall@arm.com> <20170424175839.5262-2-julien.grall@arm.com> Cc: sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, linux-efi@vger.kernel.org, Juergen Gross , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org From: Boris Ostrovsky Message-ID: <41fd4caf-7554-7d54-6332-d227228a13ea@oracle.com> Date: Mon, 24 Apr 2017 14:21:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170424175839.5262-2-julien.grall@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1690 Lines: 56 On 04/24/2017 01:58 PM, Julien Grall wrote: > The helper xen_reboot will be called by the EFI code in a later patch. > > Note that the ARM version does not yet exist and will be added in a > later patch too. > > Signed-off-by: Julien Grall I don't think these changes are worth a whole patch. They can be folded into the third patch. -boris > > --- > > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > > Changes in v2: > - Patch added > --- > arch/x86/xen/enlighten.c | 2 +- > include/xen/xen-ops.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index ec1d5c46e58f..563f2d963a04 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1294,7 +1294,7 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { > .end_context_switch = xen_end_context_switch, > }; > > -static void xen_reboot(int reason) > +void xen_reboot(int reason) > { > struct sched_shutdown r = { .reason = reason }; > int cpu; > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h > index b5486e648607..fc5ddb472f86 100644 > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -22,6 +22,8 @@ void xen_timer_resume(void); > void xen_arch_resume(void); > void xen_arch_suspend(void); > > +void xen_reboot(int reason); > + > void xen_resume_notifier_register(struct notifier_block *nb); > void xen_resume_notifier_unregister(struct notifier_block *nb); >