Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1173740AbdDXSYq (ORCPT ); Mon, 24 Apr 2017 14:24:46 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36231 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S972323AbdDXSYh (ORCPT ); Mon, 24 Apr 2017 14:24:37 -0400 Subject: Re: [PATCH 3/3 v2] xen: Implement EFI reset_system callback To: Julien Grall , xen-devel@lists.xen.org References: <20170424175839.5262-1-julien.grall@arm.com> <20170424175839.5262-4-julien.grall@arm.com> Cc: sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, linux-efi@vger.kernel.org, Juergen Gross , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org From: Boris Ostrovsky Message-ID: <13e9e915-ecd8-0664-6789-d6e7887182e6@oracle.com> Date: Mon, 24 Apr 2017 14:23:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170424175839.5262-4-julien.grall@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 16 On 04/24/2017 01:58 PM, Julien Grall wrote: > When rebooting DOM0 with ACPI on ARM64, the kernel is crashing with the stack > trace [1]. > > This is happening because when EFI runtimes are enabled, the reset code > (see machine_restart) will first try to use EFI restart method. > > However, the EFI restart code is expecting the reset_system callback to > be always set. This is not the case for Xen and will lead to crash. > > The EFI restart helper is used in multiple places and some of them don't > not have fallback (see machine_power_off). So implement reset_system > callback as a call to xen_reboot when using EFI Xen. Reviewed-by: Boris Ostrovsky