Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S976120AbdDXTqg (ORCPT ); Mon, 24 Apr 2017 15:46:36 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:60898 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S975298AbdDXTq2 (ORCPT ); Mon, 24 Apr 2017 15:46:28 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean References: <063D6719AE5E284EB5DD2968C1650D6DCFFD98E2@AcuExch.aculab.com> To: David Laight , "'Shuah Khan'" , "bamvor.zhangjian@linaro.org" , "benh@kernel.crashing.org" , "paulus@samba.org" , "mpe@ellerman.id.au" , "dvhart@infradead.org" Cc: "linux-kselftest@vger.kernel.org" , "rkrcmar@redhat.com" , "dsafonov@virtuozzo.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "emilio.lopez@collabora.co.uk" , "linux-gpio@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "luto@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "mingo@kernel.org" , Shuah Khan From: Shuah Khan Message-ID: <8845c13f-eaeb-86a1-1ac8-d7c52e934ef4@kernel.org> Date: Mon, 24 Apr 2017 13:46:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DCFFD98E2@AcuExch.aculab.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfHknxcbArIGnPfnPIrc+L3mNnoni0i7BW12AlPbsQq737d3aOnMSG3CXYkSy1+w159YXfuEVckGeZh1eU2eH/ugXXNo4ZqsjBMtTltBSrAOBsV+scf92 WqSxyoDPhjpfeIReA4tIGgNonVmOhLT6xhjU2siKvIR68FXHFXOWazaOQQUhnxOZndqjpiJVt2/ygU+gujQ31NZPVC110iedFTSE+iBWCCDdK4TJbbqyOrFG Bda5KTRDfiroFypCHQNulnkiXeCMPgVf3dtggwc1tg76KvQeuBYfqGcWfcL/UmyNV4D3Ksjj1dUCIGM2PSL7wzPALzA1PnWiXFq0r+k7juuX9gteAYA2rn3K eAjVlEObVC56pp0PagdpQv6vlNx0cUWpUeiPeX7OiKRWAVmqB41rtFgzMZGz+JbDK3e+xWz19LEN7MKX7Bcoh5ieNElrIbqgvCK1TJuqUlS4Cr6Bk9d0Modp HxOZpRMVaWvCa1aaGllGfdmdaQy2XpLjZh52EHwNHfa/tq6Du0Hl0G8D9fA+6Ls7zZRGV7cFpdYUNa5mmgB3YhLGtnUP3/3I8NKT9TxSi01mmBZUXIWHVDt8 UaaBzL3Ffohxn9v2MwKaXxX4Vel09djX+yPP/mQPJCmRJjZU05LH149WV/6z74VGGSqn3eURpV/HEvMqfnxFuRJsZrfH9J7NJRqVsa5SskRcXaVc3+e2TlgY 0pniF0esXW1WiEafIZruvkFHzVi8MtBFBkrsVCN5CpAITiCDgsrkNDHaOHoNlRULKSjpOsqEV81aVI8+3gufvFkyek6xf4/r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 46 On 04/24/2017 09:45 AM, David Laight wrote: > From: Shuah Khan >> Sent: 22 April 2017 00:15 >> Define CLEAN macro to allow Makefiles to override common clean target >> in lib.mk. This will help fix the following failures: >> >> warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> >> Signed-off-by: Shuah Khan >> --- >> tools/testing/selftests/lib.mk | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index 775c589..959273c 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -51,8 +51,12 @@ endef >> emit_tests: >> $(EMIT_TESTS) >> >> -clean: >> +define CLEAN >> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) >> +endef >> + >> +clean: >> + $(CLEAN) > > If might be easier to do something like: > > ifneq($(NO_CLEAN),y) > clean: > $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) > endif > > David > I am not sure that it is easier. Defining a macro would work well in this case to override and also works well with what we are doing for other overrides we already have such as EMIT_TESTS. thanks, -- Shuah