Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S977004AbdDXTs4 (ORCPT ); Mon, 24 Apr 2017 15:48:56 -0400 Received: from resqmta-po-03v.sys.comcast.net ([96.114.154.162]:40002 "EHLO resqmta-po-03v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S973247AbdDXTsq (ORCPT ); Mon, 24 Apr 2017 15:48:46 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings References: <31b94c5cb9a8f71fd3888b648f32c0bd91e4a9bd.1492815938.git.shuahkh@osg.samsung.com> <87o9vpyp6h.fsf@concordia.ellerman.id.au> <063D6719AE5E284EB5DD2968C1650D6DCFFD9941@AcuExch.aculab.com> To: David Laight , "'Michael Ellerman'" , Shuah Khan , "bamvor.zhangjian@linaro.org" , "benh@kernel.crashing.org" , "paulus@samba.org" , "dvhart@infradead.org" Cc: "linux-kselftest@vger.kernel.org" , "rkrcmar@redhat.com" , "dsafonov@virtuozzo.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "emilio.lopez@collabora.co.uk" , "linux-gpio@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "luto@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "mingo@kernel.org" , Shuah Khan From: Shuah Khan Message-ID: <83d77bfe-6219-950e-82e0-4601a8ed010c@kernel.org> Date: Mon, 24 Apr 2017 13:48:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DCFFD9941@AcuExch.aculab.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfK6nV5uFFiVdNqsdL63Dy1P6ElMuCKCO0/M7rvyiQ9liTGnLRMUn/Ws804NS+yl0JiDZi5rKchpDf114uG+k9xZJCFAdfUTiJWbcRurCe6xDiP11kf8g bw2ODDuue98KtMrGoK8wJ/OP5kiRdkEGrGe4uIx9Kv//rz5sO405haTT1BWVyc7nYXlwNuZ7wf/ZUfA5ePBz13EWgt9gjqAz4yxDTYza0Gwfr483etpZDxpX f8fJARSQWAnAEICZjgBpv8uVCJDHl4pNQlswI/TbUDpXH03O6Py7+TTIxqR+LiP0948IhkuxuT55MsfiloW/fWSOahyUKbgxdTtmqGqcPM4WQQTAlneRhuI4 oNx+q3qbqwJf5difkoiLpp9fdxJGej/+DkAVshNITUl/OR5K7itG4d+sAMz2dO1YSj2xAqZxpBlDeUWjd26dZ7MVH45jnMZHKvvjH0S45PrGk29/+9cavojX S6Jya9zHN96t3uPSAnnzCGr74X6BDT7R6LqCtYr+ih6KcE4WjXWfxF0XO+mkVvwn4Mfp7uOpSc1BWSby7R5VT8F5Axk7fc7xvsP60Hu11kF8qxrTP6eHePvy ZYAKFow52ikp2b478HbmhUrbkcU5lUHFmJUqHAct0tUM8HwmaQP8GEdkV1zVaGOdpyvB6JXmZ78278Qtm2d0YLuOBY/AvnjUx98BR0o0I4lebLMKZKb1/yEJ WNT5KD9Do62chNIs41tvSkhiriD73Ta4xfYTHp0ZMp5V/HqGaeSRVyzdW5/rngKliGgxXOLzfNtmxyXVtaSkr6uRiH1YZ5tK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 44 On 04/24/2017 09:57 AM, David Laight wrote: > From: Linuxppc-dev Michael Ellerman >> Shuah Khan writes: >> >>> Add override for lib.mk clean to fix the following warnings from clean >>> target run. >>> >>> Makefile:44: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> >>> Signed-off-by: Shuah Khan >>> --- >>> tools/testing/selftests/x86/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>> index 38e0a9c..4d27550 100644 >>> --- a/tools/testing/selftests/x86/Makefile >>> +++ b/tools/testing/selftests/x86/Makefile >>> @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) >>> >>> all_64: $(BINARIES_64) >>> >>> -clean: >>> +override define CLEAN >>> $(RM) $(BINARIES_32) $(BINARIES_64) >>> +endef >> >> Simpler as: >> >> EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > > Actually for builds that insist on crapping all over the source tree I've used: > > clean: > rm -rf `cat .cvsignore 2>/dev/null` > > David This will have to be done as a separate change. The warnings I am fixing are related to common clean target in lib.mk and the need to override. thanks, -- Shuah