Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263023AbTFDOol (ORCPT ); Wed, 4 Jun 2003 10:44:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263349AbTFDOol (ORCPT ); Wed, 4 Jun 2003 10:44:41 -0400 Received: from spanner.eng.cam.ac.uk ([129.169.8.9]:24023 "EHLO spanner.eng.cam.ac.uk") by vger.kernel.org with ESMTP id S263023AbTFDOok (ORCPT ); Wed, 4 Jun 2003 10:44:40 -0400 Date: Wed, 4 Jun 2003 15:58:06 +0100 (BST) From: "P. Benie" To: Linus Torvalds cc: Christoph Hellwig , Kernel Mailing List Subject: Re: [PATCH] [2.5] Non-blocking write can block In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 23 On Wed, 4 Jun 2003, Linus Torvalds wrote: > No no no, it's wrong. > > If you do something like this, then you also have to teach "select()" > about this, otherwise you just get busy looping in applications. > > In general, we shouldn't do this, unless somebody can show an application > where it really matters. I wrote the patch to solve a real-world problem with wall(1), which occasionally gets stuck writing to somebody's tty. I think it's reasonable for wall to assume that non-blocking writes are non-blocking. I'll think about how to do the patch correctly. Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/