Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978460AbdDXViB (ORCPT ); Mon, 24 Apr 2017 17:38:01 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33004 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S978064AbdDXVhz (ORCPT ); Mon, 24 Apr 2017 17:37:55 -0400 MIME-Version: 1.0 In-Reply-To: <20170424212908.10055-1-madman2003@shikahr.net> References: <20170424212908.10055-1-madman2003@shikahr.net> From: Andy Shevchenko Date: Tue, 25 Apr 2017 00:37:53 +0300 Message-ID: Subject: Re: [PATCH] platform/x86/intel-vbtn: add volume up and down To: Maarten Maathuis Cc: AceLan Kao , "dvhart@infradead.org" , Platform Driver , "linux-kernel@vger.kernel.org" , Maarten Maathuis Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 45 On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis wrote: > Tested on HP Elite X2 1012 G1. > Matches event report of Lenovo Helix 2 > (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). > Much better! > V2: Fix indent and add sign-off Usually this line goes after --- (body delimiter). No need to resend this time. I would wait a bit for actual author/driver maintainer to comment. Otherwise patch looks good enough to me. > > Signed-off-by: Maarten Maathuis > --- > drivers/platform/x86/intel-vbtn.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c > index 554e82ebe83c..1616cb9c4ae5 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = { > static const struct key_entry intel_vbtn_keymap[] = { > { KE_IGNORE, 0xC0, { KEY_POWER } }, /* power key press */ > { KE_KEY, 0xC1, { KEY_POWER } }, /* power key release */ > + { KE_KEY, 0xC4, { KEY_VOLUMEUP} }, /* volume-up key press */ > + { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ > + { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ > + { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ > { KE_END }, > }; > > -- > 2.12.2 > -- With Best Regards, Andy Shevchenko