Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978808AbdDXWSM (ORCPT ); Mon, 24 Apr 2017 18:18:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50757 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S978741AbdDXWSD (ORCPT ); Mon, 24 Apr 2017 18:18:03 -0400 To: Alexey Khoroshilov Cc: Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case From: "Martin K. Petersen" Organization: Oracle Corporation References: <1492988460-453-1-git-send-email-khoroshilov@ispras.ru> Date: Mon, 24 Apr 2017 18:17:18 -0400 In-Reply-To: <1492988460-453-1-git-send-email-khoroshilov@ispras.ru> (Alexey Khoroshilov's message of "Mon, 24 Apr 2017 02:01:00 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 401 Lines: 14 Alexey, > As Christoph Hellwig noted, SCSI commands that transfer data > always have a SG entry. The patch removes dead code in > mvumi_make_sgl(), mvumi_complete_cmd() and mvumi_timed_out() > that handle zero scsi_sg_count(scmd) case. > > Also the patch adds pci_unmap_sg() on failure path in mvumi_make_sgl(). Applied to 4.12/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering