Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978881AbdDXWaT (ORCPT ); Mon, 24 Apr 2017 18:30:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19173 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S978864AbdDXWaI (ORCPT ); Mon, 24 Apr 2017 18:30:08 -0400 To: Finn Thain , Ondrej Zary , Michael Schmitz Cc: "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock From: "Martin K. Petersen" Organization: Oracle Corporation References: <1ecb1ec37388c616335dba37b42b4a7676df6c1e.1491115954.git.fthain@telegraphics.com.au> Date: Mon, 24 Apr 2017 18:29:50 -0400 In-Reply-To: <1ecb1ec37388c616335dba37b42b4a7676df6c1e.1491115954.git.fthain@telegraphics.com.au> (Finn Thain's message of "Sun, 02 Apr 2017 17:08:05 +1000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 456 Lines: 15 Finn, > Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips") > added mac_scsi_esp_intr() to handle the IRQ lines from a pair of on-board > ESP chips (a normal shared IRQ did not work). > > Proper mutual exclusion was missing from that patch. This patch fixes > race conditions between comparison and assignment of esp_chips[] > pointers. Ondrej/Michael: Mind reviewing this change? -- Martin K. Petersen Oracle Linux Engineering