Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978981AbdDXWsa (ORCPT ); Mon, 24 Apr 2017 18:48:30 -0400 Received: from ozlabs.org ([103.22.144.67]:34289 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S978896AbdDXWrc (ORCPT ); Mon, 24 Apr 2017 18:47:32 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 2f59be5b970b503ca8db1cb723b155e455ebac8e In-Reply-To: <5aa5ca47d531a530285fe5b453f6921d0960bde3.1492606062.git.naveen.n.rao@linux.vnet.ibm.com> To: "Naveen N. Rao" From: Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Masami Hiramatsu , Ingo Molnar Subject: Re: [v4,2/6] powerpc: ftrace: restore LR from pt_regs Message-Id: <3wBhLT756kz9s8S@ozlabs.org> Date: Tue, 25 Apr 2017 08:47:29 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 17 On Wed, 2017-04-19 at 12:52:24 UTC, "Naveen N. Rao" wrote: > Pass the real LR to the ftrace handler. This is needed for > KPROBES_ON_FTRACE for the pre handlers. > > Also, with KPROBES_ON_FTRACE, the link register may be updated by the > pre handlers or by a registed kretprobe. Honor updated LR by restoring > it from pt_regs, rather than from the stack save area. > > Live patch and function graph continue to work fine with this change. > > Signed-off-by: Naveen N. Rao Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/2f59be5b970b503ca8db1cb723b155 cheers