Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978534AbdDXXCE (ORCPT ); Mon, 24 Apr 2017 19:02:04 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34133 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S977064AbdDXXB4 (ORCPT ); Mon, 24 Apr 2017 19:01:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <1492813704-32280-1-git-send-email-okaya@codeaurora.org> From: "Rafael J. Wysocki" Date: Tue, 25 Apr 2017 01:01:55 +0200 X-Google-Sender-Auth: yqIRcczMmgdK43Pkw3xcoWAAVLo Message-ID: Subject: Re: [PATCH] ACPI / GED: use late init to allow other drivers init To: Sinan Kaya Cc: "Rafael J. Wysocki" , ACPI Devel Maling List , Timur Tabi , "Rafael J. Wysocki" , Len Brown , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 20 On Sat, Apr 22, 2017 at 12:48 AM, Sinan Kaya wrote: > On 4/21/2017 6:43 PM, Rafael J. Wysocki wrote: >>> +late_initcall(ged_init); >> Does this fix the problem? >> >> What about if the module in question is loaded after running late_initcalls? > > This fixed the issue for me where I had dependencies for QUP I2C driver and GHES > drivers. Both of them are modules and get probed via normal module execution path. > > However, I'm open to improvements. Do you have a better suggestion? I can try > to add some _DEP stuff if it is present, but I remember Linux doesn't like _DEP > stuff too much. My point is that nothing guarantees a specific ordering or timing of module loading in general, so moving stuff to different initcall levels does not really help 100% of the time. Thanks, Rafael