Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1174568AbdDXX6L (ORCPT ); Mon, 24 Apr 2017 19:58:11 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:32953 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S979364AbdDXX6A (ORCPT ); Mon, 24 Apr 2017 19:58:00 -0400 Subject: Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360. To: Eric Anholt , Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org References: <20170424215022.30382-1-eric@anholt.net> <20170424215022.30382-2-eric@anholt.net> <8760hte4zw.fsf@eliezer.anholt.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason From: Scott Branden Message-ID: <8054ec9e-73d0-af1a-bb9a-fcdac782dc9c@broadcom.com> Date: Mon, 24 Apr 2017 16:57:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <8760hte4zw.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 35 On 17-04-24 04:54 PM, Eric Anholt wrote: > Scott Branden writes: > >> Minor comment in line >> >> On 17-04-24 02:50 PM, Eric Anholt wrote: >>> Cygnus is a small family of SoCs, of which we currently have >>> devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the >>> same as 58xx, just requiring a tiny bit of setup that was previously >>> missing. >>> >>> Signed-off-by: Eric Anholt >>> --- >>> Documentation/devicetree/bindings/net/dsa/b53.txt | 3 +++ >>> drivers/net/dsa/b53/b53_srab.c | 2 ++ >>> 2 files changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt >>> index d6c6e41648d4..49c93d3c0839 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt >>> @@ -29,6 +29,9 @@ Required properties: >>> "brcm,bcm58625-srab" >>> "brcm,bcm88312-srab" and the mandatory "brcm,nsp-srab string >>> >>> + For the BCM11360 SoC, must be: >>> + "brcm,bcm11360-srab" and the mandatory "brcm,cygnus-srab string >>> + >> place in alphabetical order in the doc? > > Moved it above BCM5310x now. I hope that's what you meant. > Yes, sorry for not being more clear.