Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S979986AbdDYCPL (ORCPT ); Mon, 24 Apr 2017 22:15:11 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36670 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S979949AbdDYCO4 (ORCPT ); Mon, 24 Apr 2017 22:14:56 -0400 Subject: Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock To: "Martin K. Petersen" , Finn Thain , Ondrej Zary References: <1ecb1ec37388c616335dba37b42b4a7676df6c1e.1491115954.git.fthain@telegraphics.com.au> Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Michael Schmitz Message-ID: Date: Tue, 25 Apr 2017 14:14:47 +1200 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 21 Martin, looks good to me, so: Reviewed-By: Michael Schmitz Am 25.04.2017 um 10:29 schrieb Martin K. Petersen: > > Finn, > >> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips") >> added mac_scsi_esp_intr() to handle the IRQ lines from a pair of on-board >> ESP chips (a normal shared IRQ did not work). >> >> Proper mutual exclusion was missing from that patch. This patch fixes >> race conditions between comparison and assignment of esp_chips[] >> pointers. > > Ondrej/Michael: Mind reviewing this change? >