Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165425AbdDYGuQ convert rfc822-to-8bit (ORCPT ); Tue, 25 Apr 2017 02:50:16 -0400 Received: from smtprelay.restena.lu ([158.64.1.62]:47043 "EHLO smtprelay.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164724AbdDYGuB (ORCPT ); Tue, 25 Apr 2017 02:50:01 -0400 X-Greylist: delayed 546 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Apr 2017 02:50:00 EDT Date: Tue, 25 Apr 2017 08:40:51 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: SF Markus Elfring Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Benjamin Tissoires , Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by seq_puts() in picolcd_debug_reset_show() Message-ID: <20170425084051.5b981b48@pluto.restena.lu> In-Reply-To: References: <2d526d72-a740-367b-04a9-ed698435f8ed@users.sourceforge.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 32 Acked-by: Bruno Prémont On Mon, 24 Apr 2017 22:23:02 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Apr 2017 21:27:42 +0200 > > Strings which did not contain data format specifications should be put > into a sequence. Thus use the corresponding function "seq_puts". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/hid/hid-picolcd_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c > index 3e0feb4bb538..975f36601d59 100644 > --- a/drivers/hid/hid-picolcd_debugfs.c > +++ b/drivers/hid/hid-picolcd_debugfs.c > @@ -33,9 +33,9 @@ > static int picolcd_debug_reset_show(struct seq_file *f, void *p) > { > if (picolcd_fbinfo((struct picolcd_data *)f->private)) > - seq_printf(f, "all fb\n"); > + seq_puts(f, "all fb\n"); > else > - seq_printf(f, "all\n"); > + seq_puts(f, "all\n"); > return 0; > } >