Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1170510AbdDYHEM (ORCPT ); Tue, 25 Apr 2017 03:04:12 -0400 Received: from edison.jonmasters.org ([173.255.233.168]:60730 "EHLO edison.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760744AbdDYHEE (ORCPT ); Tue, 25 Apr 2017 03:04:04 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) From: Jon Masters X-Mailer: iPhone Mail (14E304) In-Reply-To: <161cb1b4-ccdc-fba1-c272-45b8ed261cb2@jonmasters.org> Date: Tue, 25 Apr 2017 03:04:02 -0400 Cc: Rusty Russell , "Peter Zijlstra (Intel)" , Josh Poimboeuf , Ard Biesheuvel , Heinrich Schuchardt , Nicholas Piggin , Chris Metcalf , linux-kernel@vger.kernel.org, Lucas De Marchi Content-Transfer-Encoding: 7bit Message-Id: <065F583B-6150-45D6-A84B-757F63A6242E@jonmasters.org> References: <1492814127-66318-1-git-send-email-keescook@chromium.org> <1492814127-66318-3-git-send-email-keescook@chromium.org> <161cb1b4-ccdc-fba1-c272-45b8ed261cb2@jonmasters.org> To: Kees Cook , Jessica Yu X-SA-Exim-Connect-IP: 74.92.29.237 X-SA-Exim-Mail-From: jcm@jonmasters.org Subject: Re: [PATCH v2 2/2] module: Add module name to modinfo X-SA-Exim-Version: 4.2.1 (built Sun, 08 Nov 2009 07:31:22 +0000) X-SA-Exim-Scanned: Yes (on edison.jonmasters.org) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 22 Nevermind. Missread the patch as doing something different on first pass. -- Computer Architect | Sent from my 64-bit #ARM Powered phone > On Apr 25, 2017, at 03:00, Jon Masters wrote: > >> On 04/21/2017 06:35 PM, Kees Cook wrote: >> >> Accessing the mod structure (e.g. for mod->name) prior to having completed >> check_modstruct_version() can result in writing garbage to the error logs >> if the layout of the mod structure loaded from disk doesn't match the >> running kernel's mod structure layout. This kind of mismatch will become >> much more likely if a kernel is built with different randomization seed >> for the struct layout randomization plugin. >> >> Instead, add and use a new modinfo string for logging the module name. > > +Lucas - probably something that the modinfo kmod utility should track. > > Jon. >