Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1177344AbdDYJUV (ORCPT ); Tue, 25 Apr 2017 05:20:21 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:36362 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1176908AbdDYJUN (ORCPT ); Tue, 25 Apr 2017 05:20:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <6e0f0b52-27a1-0ce5-c217-3aa941babe63@siemens.com> From: Andy Shevchenko Date: Tue, 25 Apr 2017 12:20:11 +0300 Message-ID: Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 To: Peter Meerwald-Stadler Cc: Jan Kiszka , Jonathan Cameron , linux-iio@vger.kernel.org, Linux Kernel Mailing List , Sascha Weisenberger , Andy Shevchenko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 18 On Tue, Apr 25, 2017 at 10:31 AM, Peter Meerwald-Stadler wrote: > >> This is an upstream port of an IIO driver for the TI ADC108S102 and >> ADC128S102. The former can be found on the Intel Galileo Gen2 and the >> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is >> included. > I think board-specific stuff should not go into the driver -> DT? World is not ARM/DT only -> Unified Device Properties, yes. P.S. I agree with everything else, though it looks a bit overlapping with my review, which is a good sign to me :-) -- With Best Regards, Andy Shevchenko