Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428698AbdDYJgD (ORCPT ); Tue, 25 Apr 2017 05:36:03 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:34007 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1428741AbdDYJfL (ORCPT ); Tue, 25 Apr 2017 05:35:11 -0400 Subject: Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360. To: Eric Anholt , Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org References: <20170424215022.30382-1-eric@anholt.net> <20170424215022.30382-2-eric@anholt.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason From: Sergei Shtylyov Message-ID: Date: Tue, 25 Apr 2017 12:35:08 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170424215022.30382-2-eric@anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 31 Hello! On 4/25/2017 12:50 AM, Eric Anholt wrote: > Cygnus is a small family of SoCs, of which we currently have > devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the > same as 58xx, just requiring a tiny bit of setup that was previously > missing. > > Signed-off-by: Eric Anholt > --- > Documentation/devicetree/bindings/net/dsa/b53.txt | 3 +++ > drivers/net/dsa/b53/b53_srab.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt > index d6c6e41648d4..49c93d3c0839 100644 > --- a/Documentation/devicetree/bindings/net/dsa/b53.txt > +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt > @@ -29,6 +29,9 @@ Required properties: > "brcm,bcm58625-srab" > "brcm,bcm88312-srab" and the mandatory "brcm,nsp-srab string > > + For the BCM11360 SoC, must be: > + "brcm,bcm11360-srab" and the mandatory "brcm,cygnus-srab string Missing closing quote here and above? [...] MBR, Sergei